1402362 - nsURLHelper.h: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Building Firefox trunk with enable-warning-as-error with clang trunk is failing on:

In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/security/manager/ssl/Unified_cpp_security_manager_ssl0.cpp:110:
In file included from /data/jenkins/workspace/firefox-clang-last/security/manager/ssl/SSLServerCertVerification.cpp:132:
/data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/nsURLHelper.h:228:35: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic]
     return net_FindCharInSet(str, NET_MAX_ADDRESS, set);
                                   ^~~~~~~~~~~~~~~
 /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/nsURLHelper.h:224:36: note: expanded from macro 'NET_MAX_ADDRESS'
 #define NET_MAX_ADDRESS (((char*)0)-1)
                          ~~~~~~~~~~^
 /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/nsURLHelper.h:232:38: error: performing pointer arithmetic on a null pointer has undefined behavior if the offset is nonzero [-Werror,-Wnull-pointer-arithmetic]
     return net_FindCharNotInSet(str, NET_MAX_ADDRESS, set);
                                      ^~~~~~~~~~~~~~~
 /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/dist/include/nsURLHelper.h:224:36: note: expanded from macro 'NET_MAX_ADDRESS'
 1:06.57 #define NET_MAX_ADDRESS (((char*)0)-1)
 1:06.57                          ~~~~~~~~~~^
 1:07.96 2 errors generated.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Looks like it is caused by this upstream change:
https://reviews.llvm.org/D37042

Comment 2

[Andi [:andi]]

Attachment: Bug 1402362 - modified NET_MAX_ADDRESS to have UINTPTR_MAX value.

Review commit: https://reviewboard.mozilla.org/r/183982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183982/

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8912653 [details]
Bug 1402362 - modified NET_MAX_ADDRESS to have UINTPTR_MAX value.

https://reviewboard.mozilla.org/r/183982/#review189170

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74462a725efc
modified NET_MAX_ADDRESS to have UINTPTR_MAX value. r=valentin

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/74462a725efc