1402390 - CamelCase all React component files in \devtools\client\netmonitor\src\components\

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Patrick Brosset <:pbro>]

We recently agreed to name our React component file names using the CamelCase convention.

However the files in \devtools\client\netmonitor\src\components\ do not follow this convention, so let's rename them.

This is an easy fix, but make sure you read the contribution docs before starting: http://docs.firefox-dev.tools/ so that you can build Firefox locally and verify that things still work after your change.
After building, just running the built Firefox and opening the network panel should be enough of a test that things still work.

Comment 1

[Miguel Useche]

Can I take this? I wanna start collaborating

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to migueluseche from comment #1)
> Can I take this? I wanna start collaborating
Excellent, assigned to you!

Honza

Comment 3

[Patrick Brosset <:pbro>]

Hey Miguel. Are you still interested in taking this one? Do you need any help?

Comment 4

[Patrick Brosset <:pbro>]

I meant to needinfo Miguel, not myself obviously ...

Comment 5

[Miguel Useche]

Yes, I just need to resolve how to avoid losing history changes for bug 1402391 and I'll do this.

Comment 6

[Miguel Useche]

1402391 is finished so I'm gonna move to work on this. I'll send a patch in few days.

Comment 7

[Miguel Useche]

Attachment: Patch to rename files to PascalCase and fix any problem with it.

This is the patch to rename files and update code to support it. I applied tests and they passed.

Comment 8

[Patrick Brosset <:pbro>]

Comment on attachment 8918720 [details] [diff] [review]
Patch to rename files to PascalCase and fix any problem with it.

Review of attachment 8918720 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.
I just see one thing missing: the webconsole also imports some of the netmonitor's components (to show network requests in the console), so you'll need to change some require paths in webconsole too. I did a quick search and found this:

devtools\client\webconsole\new-console-output\components\message-types\NetworkEventMessage.js:
   18: const TabboxPanel = createFactory(require("devtools/client/netmonitor/src/components/tabbox-panel"));

devtools\client\webconsole\new-console-output\test\require-helper.js:
   39:     case "devtools/client/netmonitor/src/components/tabbox-panel":

Comment 9

[Miguel Useche]

Attachment: bug-1402390.patch

Updated patch to add changes for WebConsole. I didn't find any other includes in the rest of the code.

Comment 10

[Patrick Brosset <:pbro>]

Thanks for fixing this.
I don't know how this happened, but your second patch does not contain all of the changes that your first patch had.
So I fixed that locally, and pushed to try. I'll re-upload your complete patch here in a second.
Here's the try CI url: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62dafb0b420d75498f782d3b85e8959acb1fd336

Comment 11

[Patrick Brosset <:pbro>]

Attachment: bug-1402390.patch

This is your patch. Just fixed to make sure all changes appear. I've preserved your name as the author.
Looking good, so R+.
Let's wait for try results to come back.

Comment 12

[Miguel Useche]

Thanks, sorry about the patch. I don't know what happened.

Comment 13

[Patrick Brosset <:pbro>]

That's ok. This was easy to fix. Thanks for your work!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9473b60e5eeb
CamelCase all React component files in \devtools\client\netmonitor\src\components\. r=pbro

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9473b60e5eeb

Comment 16

[Kelsey Gilbert [:jgilbert]]

Please don't case-sensitive rename files. Windows git freaks out when checking out across them.