1402772 - Change nsIEventListenerChange::changedListenerNames

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Nicholas Nethercote [inactive]]

nsIEventListenerChange::changedListenerNames is an nsIArray attribute that
contains nsIAtoms. Bug 1396693 made it `noscript` to help with nsIAtom
deCOMtamination (bug 1392883) but more changes are needed: that array
eventually needs to be changed to nsTArray<RefPtr<nsIAtom>>, but we can't
easily use that type via XPIDL.

However, the attribute has a single use, in a11y code. That code merely
iterates over the list and counts how many atoms it contains that match
"onclick", "onmousedown", and "onmouseup".

So this patch moves that counting functionality inside nsEventListenerChange
by changing the attribute to
`countOfEventListenerChangesAffectingAccessibility`. This saves us from having
to expose the array of atoms via XPIDL.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Change nsIEventListenerChange::changedListenerNames

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8911683 [details] [diff] [review]
Change nsIEventListenerChange::changedListenerNames

"Change nsIEventListenerChange::changedListenerNames. r=smaug." is a bit vague commit message, I mean as the main part of the commit message.

And nsTArray<RefPtr<nsIAtom>> can be quite easily used in idl files (like any C++), so perhaps remove that comment.

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e2959069bc35bfa468203980316ff63ca388b28
Bug 1402772 - Change nsIEventListenerChange::changedListenerNames to a count of a11y-affecting elements. r=smaug.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0e2959069bc3