1402784 - Add "audioworklet" as a possible destination on a Fetch `request`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Paul Adenot (:padenot)]

Associated spec issue: https://github.com/whatwg/fetch/pull/527

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Mirroring the priority of bug 1062849. 
Paul, feel free to change the priority as you see fit according to the latest AudioWorklet plan.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1402784 - Introduce nsIContentPolicy::TYPE_INTERNAL_AUDIOWORKLET and nsIContentPolicy::TYPE_INTERNAL_PAINTWORKLET, r?ckerschb

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1402784 - Use nsIContentPolicy::TYPE_INTERNAL_AUDIOWORKLET and nsIContentPolicy::TYPE_INTERNAL_PAINTWORKLET in Worklet code, r?smaug

Depends on D67105

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1402784 - Request.destination audioworklet WPT, r?padenot

Depends on D67106

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95e4acb5e6e7
Introduce nsIContentPolicy::TYPE_INTERNAL_AUDIOWORKLET and nsIContentPolicy::TYPE_INTERNAL_PAINTWORKLET, r=ckerschb
https://hg.mozilla.org/integration/autoland/rev/367f64f2dd1b
Use nsIContentPolicy::TYPE_INTERNAL_AUDIOWORKLET and nsIContentPolicy::TYPE_INTERNAL_PAINTWORKLET in Worklet code, r=smaug
https://hg.mozilla.org/integration/autoland/rev/2ca9d49fdbf9
Request.destination audioworklet WPT, r=annevk

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22389 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/95e4acb5e6e7
https://hg.mozilla.org/mozilla-central/rev/367f64f2dd1b
https://hg.mozilla.org/mozilla-central/rev/2ca9d49fdbf9

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

• Updated Request.destination with some information about script-based destinations
• Updated the BCD records but have not yet submitted as it's part of the overall update to audioworklet. Will be pushed soon. Adds the destination types to RequestDestination.json
• Added a mention of this change to Firefox 76 for developers

Comment 11

[Mike Pennisi [:jugglinmike]]

The referenced specification issue does not actually specify the behavior
implemented here; it only extends Fetch so that this behavior can be specified
elsewhere.

The Web Audio specification still makes no mention of the "audioworklet"
request destination. Before it can do that, the Worklets spec needs an
extension [1].

Completing this will justify the non-normative table in Fetch [2] and the
shared tests in WPT. It may also motivate Chromium to align with Firefox
(today, it uses the value "script" as per the spec [3]).

Andrea: do you have the bandwidth to wrap this up?

[1] https://github.com/w3c/css-houdini-drafts/issues/378
[2] https://fetch.spec.whatwg.org/#requests
[3] https://github.com/chromium/chromium/blob/2cf7a7c941a5bea2ac535365d841b63c28ad2084/third_party/blink/common/loader/request_destination.cc

Comment 12

[Andrea Marchesini [:baku]]

Unfortunately, I don't have time to work on this. I can help somebody else, and I can review code, but not more than this for the next couple of months. Mike, is it something you can work on?