1402864 - Default Top Sites do not have the "Edit" option

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: different context menu for pinned visited default top sites.gif

[Notes]:
- Only the visited default Top Sites have this behavior; if you manually add or if a different Top Site is populated naturally they will have those options when pinned.

[Affected versions]:
- Firefox 58.0a1 Build ID 20170924220116

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- All of the default Top Sites were visited multiple times so that they appear in the Top Sites section. 

[Steps to reproduce]:
1. Open the browser and navigate to about:newtab.
2. Pin one of the default Top Sites (eg. youtube).
3. Click the "..." button for the pinned Top Site.
4. Observe the context menu options. 

[Expected results]:
- "Unpin", "Edit", "Open in a New Window", "Open in a New Private Window", "Dismiss", "Remove from History" options are displayed.

[Actual results]:
- "Edit" and "Remove from History" options are not displayed. 

[Additional notes]:
- Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

At least adding back the "Edit".... Splitting off remove from history

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3914

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8fe1055eb322385810376a2be8d137333e360767
fix(topsites): Allow directly editing default top sites instead of via edit mode (#3914)

Fix Bug 1402864 - Default Top Sites do not have the "Edit" option

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7d9c675dabf5

Comment 5

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the Edit button now appears when a default Top Site is pinned on the latest Nightly 59.0a1 (Build ID 20180110100224) on Arch Linux x64, Ubuntu 16.04 x86, Mac 10.12.6 and Windows 10 x64.