Closed Bug 1426787 Opened 6 years ago Closed 6 years ago

Top sites that match defaults lose "Remove from History" option when they are pinned

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 59
Iteration:
59.4 - Jan 15
Tracking Status
firefox59 --- verified
firefox60 --- verified

People

(Reporter: Mardak, Assigned: ursula)

References

Details

Attachments

(1 file)

Split from bug 1402864. See attachment 8911808 [details].
Iteration: --- → 1.27
Priority: -- → P1
Assignee: nobody → usarracini
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5cdf25ac7c21f81e9b7f81b3d38716682081b60d
fix(topsites): Add default status to pinned sites and not frecent ones (#3923)

Fix Bug 1426787 - Top sites that match defaults lose 'Remove from History' option when they are pinned
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1429530
Iteration: 1.27 → 1.26
Iteration: 1.26 → 59.4 - Jan 15
Flags: qe-verify+
QA Contact: iulia.cristescu
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Firefox: 60.0a1, Build ID 20180126035135

I have verified that this issue is no longer reproducible on Windows 10 x64, Ubuntu 14.04 x64 and Mac 10.12 with the latest Nightly build (60.0a1) installed. Now the "Remove from History" option is displayed even after a visited default "Top Site" was pinned.
Status: RESOLVED → VERIFIED
Updating the bug status and the tracking flags to reflect the current situation, based on the above comment.
Status: VERIFIED → RESOLVED
Closed: 6 years ago6 years ago
I managed to reproduce the initial issue on 59.0a1 (2017-12-22). I also can confirm that 59.0b5 build1 (20180128191456) is verified fixed across platforms (Windows 10 x64, macOS 10.13.2, Ubuntu 16.04 x64).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: