1403251 - Form validation message is shown before submission

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Regression from bug 1398409: currently form validation messages are shown before any submission; correct behavior is to only show validation message after a failed submission.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1403251 - Only display validation message when element is invalid;

Only display form validation message when the element becomes invalid
after an invalid submission, by checking the "-moz-ui-invalid"
pseudo-class.

Also fix some message visibility bugs, by making sure in more places
that we only display messages for focused elements.

Review commit: https://reviewboard.mozilla.org/r/183766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/183766/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

https://reviewboard.mozilla.org/r/183766/#review189092

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a9240b488a2
Only display validation message when element is invalid; r=sebastian

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7a9240b488a2

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1398409
[User impact if declined]: UI regression; form validation message is unexpectedly shown
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Tested code and only major change is to restore previous behavior
[String changes made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

Recent regression, taking it.
Should be in 57b4

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f2db1ec2bf72

Comment 8

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 58. Cannot verify on Beta 57, as the switchboard addon can't be installed.
Devices:
LG Nexus 5 (Android 6.0.1)
Huawei Honor 5X (Android 5.1.1)