Closed Bug 1403251 Opened 5 years ago Closed 5 years ago

Form validation message is shown before submission

Categories

(Firefox for Android Graveyard :: General, defect, P2)

All
Android
defect

Tracking

(fennec+, firefox56 unaffected, firefox57 fixed, firefox58 verified)

VERIFIED FIXED
Firefox 58
Tracking Status
fennec + ---
firefox56 --- unaffected
firefox57 --- fixed
firefox58 --- verified

People

(Reporter: jchen, Assigned: jchen)

References

Details

(Keywords: regression)

Attachments

(1 file)

Regression from bug 1398409: currently form validation messages are shown before any submission; correct behavior is to only show validation message after a failed submission.
Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

https://reviewboard.mozilla.org/r/183766/#review189092
Attachment #8912434 - Flags: review?(s.kaspari) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a9240b488a2
Only display validation message when element is invalid; r=sebastian
https://hg.mozilla.org/mozilla-central/rev/7a9240b488a2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1398409
[User impact if declined]: UI regression; form validation message is unexpectedly shown
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Tested code and only major change is to restore previous behavior
[String changes made/needed]: None
Attachment #8912434 - Flags: approval-mozilla-beta?
tracking-fennec: ? → +
Priority: -- → P2
Comment on attachment 8912434 [details]
Bug 1403251 - Only display validation message when element is invalid;

Recent regression, taking it.
Should be in 57b4
Attachment #8912434 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Nightly 58. Cannot verify on Beta 57, as the switchboard addon can't be installed.
Devices:
LG Nexus 5 (Android 6.0.1)
Huawei Honor 5X (Android 5.1.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.