Closed Bug 1398409 Opened 7 years ago Closed 7 years ago

Make FormAssistPopup work for custom tabs

Categories

(Firefox for Android Graveyard :: General, defect, P1)

All
Android
defect

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(3 files)

      No description provided.
Comment on attachment 8906712 [details]
Bug 1398409 - 1. Move FormAssistant out of browser.js;

https://reviewboard.mozilla.org/r/178448/#review183702
Attachment #8906712 - Flags: review?(s.kaspari) → review+
Comment on attachment 8906713 [details]
Bug 1398409 - 2. Use event callback to communicate FormAssistPopup actions;

https://reviewboard.mozilla.org/r/178450/#review183704
Attachment #8906713 - Flags: review?(s.kaspari) → review+
Attachment #8906714 - Flags: review?(droeh) → review?(snorp)
Comment on attachment 8906714 [details]
Bug 1398409 - 3. Add FormAssistPopup to custom tabs;

https://reviewboard.mozilla.org/r/178452/#review184432
Attachment #8906714 - Flags: review?(snorp) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99a2486f70c
1. Move FormAssistant out of browser.js; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1de7fdaa383
2. Use event callback to communicate FormAssistPopup actions; r=sebastian
https://hg.mozilla.org/integration/mozilla-inbound/rev/d190ba5c8b7f
3. Add FormAssistPopup to custom tabs; r=snorp
Comment on attachment 8906712 [details]
Bug 1398409 - 1. Move FormAssistant out of browser.js;

Beta request for all patches.

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: Custom tabs feature slated for 57 would not have the form popup / autocomplete feature.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Well-tested locally and the patches only just missed the Beta merge by a few hours.
[String changes made/needed]: None
Attachment #8906712 - Flags: approval-mozilla-beta?
Comment on attachment 8906712 [details]
Bug 1398409 - 1. Move FormAssistant out of browser.js;

This shouldn't need an uplift request to get into 57, since we are going to sync m-c to m-b again.
Attachment #8906712 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Depends on: 1403251
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: