1403333 - wr-text: Long tab titles don't fade out when text layers are enabled

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Markus Stange [:mstange]]

The fade-out effect on long tab titles is not being applied. It should happen for this very page, for example.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

webrendest only controls two sets of advanced layers now: background-images and text layers. By setting webrendest off and turning on the two advanced layers prefs manually, it's clear that this is caused by text layers specifically. (i.e. this happens with webrendest off and layers.advanced.text-layers=1)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Making title more precise. And dropping layers-free since that's the default now (patches are on autoland) and we don't care about layers-full.

Comment 3

[Aria Beingessner [:Gankra]]

I expect this is a similar situation to the nsDisplayTextOverflow situation, where the construction of the nsDisplayMask is supposed to modify/augment the nsDisplayText display item in some way, and we're not picking it up?

I don't see anything obvious from a quick search though.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

It might also be a bug in the nsDisplayMask handling that only manifests when text layers are turned on. Ethan has some fixes that also affect mask code over in bug 1395501 that might help, not sure.

Comment 5

[Markus Stange [:mstange]]

Testcase: data:text/html,<div style="mask:linear-gradient(black, transparent)">Text
The YAML for that testcase looks reasonable, so this might be a webrender bug. I'll test with Ethan's patches anyway.

Comment 6

[Markus Stange [:mstange]]

(In reply to Markus Stange [:mstange] from comment #5)
> I'll test with Ethan's patches anyway.

Or maybe not. Bug 1400034 has seriously bitrotted them.

Comment 7

[Markus Stange [:mstange]]

https://github.com/servo/webrender/issues/1765

Comment 8

[Markus Stange [:mstange]]

The webrender upgrade in bug 1403333 fixes this for the active tab, but not for background tabs, it seems. At least on Mac.

Comment 9

[Markus Stange [:mstange]]

This seems to depend on the color of the text. Black text works but anything brighter looks wrong.
I've commented on https://github.com/servo/webrender/issues/1765 .

Comment 10

[Markus Stange [:mstange]]

This has been fixed in the webrender repo. The next webrender update will fix it.

Comment 11

[Markus Stange [:mstange]]

Fixed by bug 1408461.

Comment 12

[Aria Beingessner [:Gankra]]

;_; it's actually finally fixed...