1403414 - History entry is named "New Tab" when navigating directly to a video from about:home and New Tab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Regression history system

Reproducible: always

Steps to Reproduce:
1. Open https://goo.gl/K9rrxQ

Actual Results:
History entry is named "New Tab" instead of tab title "toystory.mp4"

Expected Results:
History entry should be named "toystory.mp4"

Comment 1

[Alice0775 White]

Steps to Reproduce:
1. Create New profile and start Nightly with the profile and exit browser
2. Open https://goo.gl/K9rrxQ

Comment 2

[Alice0775 White]

Steps to Reproduce:
1. Create New profile and start Nightly with the profile and exit browser and restart
2. Open https://goo.gl/K9rrxQ

Comment 3

[Alice0775 White]

[Tracking Requested - why for this release]:Regression history system

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=01b9bea7d2ba241fba343aedf6decdcf2fac851f&tochange=3ce5a9419d5b7a976d442901c04995c22e014bf1

Regressed by: 3ce5a9419d5b	Ursula Sarracini — Bug 1396274 - Disable Activity Stream about:home in browser_aboutHome.js r=Mardak

@usarracini
Your patch seems to cause the problem, Can you look at this?

Comment 5

[Ed Lee :Mardak]

What history entry are you looking at? I visited the provided url and long clicking the back/forward button from that page or from this bugzilla page shows "toystory.mp4" ?

Comment 6

[Alice0775 White]

(In reply to Ed Lee :Mardak from comment #5)


"History" in Menubar, History sidebar, History of Library Window and History widget as well as session history of back/forward button.

Comment 7

[Alice0775 White]

You should follow the str.
Probably, Open from the URL from New Tab page is broken.

Comment 8

[Ed Lee :Mardak]

I did follow the STR. It had one step. I opened the link.

Comment 9

[Alice0775 White]

(In reply to Ed Lee :Mardak from comment #8)
> I did follow the STR. It had one step. I opened the link.

???

STR:
1. Start Nightly with new profile and exit browser and then restart browser again with the profile
2. Close Default browser dialog if any
3. Open https://goo.gl/K9rrxQ, you should type the url in address bar and hit [Enter]
4. Observe "History" in Menubar, History sidebar, History of Library Window and History widget as well as session history of back/forward button.

Comment 10

[Alice0775 White]

Alternate str:
1. Clear Recent History(Ctrl+Shift+Del) every thing
2. Open New Tab (Ctrl+T)
3. Open https://goo.gl/K9rrxQ, you should type the url in address bar and hit [Enter]
4. Observe "History" in Menubar, History sidebar, History of Library Window and History widget as well as session history of back/forward button.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0be298129be1221d42b269a61ab3911349738e70&tochange=07a7f3038e14c1594c80431318d3cdd6c8d928a6

Regressed by: 07a7f3038e14	Ed Lee — Bug 1381569 - Turn on Activity Stream by default for Nightly. r=mconley



Setting browser.newtabpage.activity-stream.enabled = false fixes the issue in both case(Comment 9 and Comment 10)

Comment 11

[Ursula Sarracini (:ursula)]

Bizarre...

Keeping browser.newtabpage.activity-stream.enabled = true but turning browser.newtabpage.activity-stream.aboutHome.enabled = false fixes the issue, which means it's not activity stream on newtab which is causing the problem, but loading it as about:home that's causing the issue. 

When opening the link in a about:newtab, I can't reproduce this issue (even with activity stream enabled), it's only reproducible if we open the link in a new window (which would be about:home). Possibly something going on with the way we switch content processes for sites that are "files" rather than websites.

I can look into what's going on here.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This seems like a bad regression, tracked for 57.

Comment 13

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Not sure if tracking-firefox57 was set in comment 12 assuming that all history pages only showed "New Tab" as the title.

I can't reproduce this issue for any normal html web pages including pages that have no title. I can't reproduce this with images or pdfs.

Activity Stream does do a `document.title = "New Tab"` and removing that does make this bug go away but then the history entry shows up with the wrong title for about:home.

This might just get fixed anyway when Activity Stream prerenders with strings, so it can just do `<title>New Tab</title>`, but until then, the title is only set after it gets its strings.

Comment 14

[Alice0775 White]

I can reproduce the problem on 58.0a1 and 57.0b3 when open the URL from New Tab as well as Home tab. See STR comment #10.

Comment 15

[Ed Lee :Mardak]

mak, we'll fix this on the activity stream side in https://github.com/mozilla/activity-stream/issues/3790 but it's not really clear how this is happening in the first place. How would setting the title dynamically on one page cause it to be set on a new page?

Comment 16

[Marco Bonardo [:mak]]

I don't know, history takes the title from the docshell, see the UpdateGlobalHistoryTitle calls there. Those calls take the current uri as input, I can only imagine for some reason the title is set on the wrong docshell, or the media docshell is particular. If you can reproduce, you could try debugging from there.

Comment 17

[Ed Lee :Mardak]

Fixed by https://github.com/mozilla/activity-stream/pull/3755 to be uplifted via bug 1413550.

Comment 18

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/6eece4a58299

Comment 19

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using an older version of Nightly (2017-09-26) on Windows 10 x64. I tested this bug using the steps from comment 2. 
I retested everything using latest Nightly 59 and beta 58.0b3 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.12, but the bug is not reproducing anymore.