Closed Bug 1413550 Opened 7 years ago Closed 7 years ago

Add per-platform styles, per-locale html and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, enhancement)

57 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: Mardak, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/95b4c35393b7192d680d1291b6960200be5e7570...firefox-58b1

Attachments

(1 file)

      No description provided.
Depends on: 1406928
Summary: Add ... and bug fixes to Activity Stream → Add per-platform styles, per-locale html and bug fixes to Activity Stream
(In reply to Ed Lee :Mardak from comment #1)
> Review commit: https://reviewboard.mozilla.org/r/196378/diff/#index_header
This includes the not-yet-newly-reviewed-nor-landed https://github.com/mozilla/activity-stream/pull/3755

Other than the export, I needed to set CLOBBER and update newly translated locales to aboutNewTabService.js and tweaked the test to print out what's the missing locale.
Depends on: 1403414
Depends on: 1411637
User Story: (updated)
Comment on attachment 8925128 [details]
Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/196378/#review201640
Attachment #8925128 - Flags: review?(khudson) → review+
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/def95432b0a1
Add per-platform styles, per-locale html and bug fixes to Activity Stream. r=k88hudson
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/6eece4a58299
Add per-platform styles, per-locale html and bug fixes to Activity Stream. r=k88hudson
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/58ad29346bba
Backed out changeset def95432b0a1 on request from Mardak for test failure. r=backout on a CLOSED TREE
Pike - are you aware of this?
Flags: needinfo?(l10n)
From the feedback we got from irc #l10n and other bugs, e.g., bug 1411452, we got rid of the big #define/#if AB_CD checks from jar.mn and did not expose js/html to repacks by packaging all add-on data in the system add-on, so now the script that loads the resource: data picks the appropriate one to use dynamically.
User Story: (updated)
https://hg.mozilla.org/mozilla-central/rev/6eece4a58299
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
To me, landing generated files per locale is a symptom, and a symptom I don't like. I can't point at the problem, nor can I suggest a solution, let alone at a solution that is within the scope of something like activity stream.
Flags: needinfo?(l10n)
Depends on: 1407244
Blocks: 1415812
Depends on: 1404374
User Story: (updated)
Blocks: 1419601
Blocks: 1414979
No longer blocks: 1415812
Blocks: 1421312
Assignee: nobody → edilee
Depends on: 1417793
Blocks: 1424987
Blocks: 1430147
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.