1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

Review commit: https://reviewboard.mozilla.org/r/196378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196378/

Comment 2

[Ed Lee :Mardak]

(In reply to Ed Lee :Mardak from comment #1)
> Review commit: https://reviewboard.mozilla.org/r/196378/diff/#index_header
This includes the not-yet-newly-reviewed-nor-landed https://github.com/mozilla/activity-stream/pull/3755

Other than the export, I needed to set CLOBBER and update newly translated locales to aboutNewTabService.js and tweaked the test to print out what's the missing locale.

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8925128 [details]
Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196378/diff/1-2/

Comment 4

[Ed Lee :Mardak]

Comment on attachment 8925128 [details]
Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196378/diff/2-3/

Comment 5

[Kate Hudson :k88hudson]

Comment on attachment 8925128 [details]
Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/196378/#review201640

Comment 6

[Ed Lee :Mardak]

Comment on attachment 8925128 [details]
Bug 1413550 - Add per-platform styles, per-locale html and bug fixes to Activity Stream.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196378/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/def95432b0a1
Add per-platform styles, per-locale html and bug fixes to Activity Stream. r=k88hudson

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eece4a58299
Add per-platform styles, per-locale html and bug fixes to Activity Stream. r=k88hudson

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58ad29346bba
Backed out changeset def95432b0a1 on request from Mardak for test failure. r=backout on a CLOSED TREE

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

Pike - are you aware of this?

Comment 11

[Ed Lee :Mardak]

From the feedback we got from irc #l10n and other bugs, e.g., bug 1411452, we got rid of the big #define/#if AB_CD checks from jar.mn and did not expose js/html to repacks by packaging all add-on data in the system add-on, so now the script that loads the resource: data picks the appropriate one to use dynamically.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6eece4a58299

Comment 13

[Axel Hecht [:Pike]]

To me, landing generated files per locale is a symptom, and a symptom I don't like. I can't point at the problem, nor can I suggest a solution, let alone at a solution that is within the scope of something like activity stream.