1403566 - Web Apps - Login auto-complete isn't working, with multiple logins saved

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P2)

Description

[Oana Horvath [:ohorvath]]

Devices: 
LG G4 (Android 6);
Build: Nightly 58.0a1 (2017-09-26);

Steps to reproduce:
1. Go to twitter.com web app and log in.
2. Save the password.
3. Log out and go back to the login page.
4. Tap the username field for autocomplete options.

Expected result:
Username & password should be auto-filled in if it was saved. If there are multiple logins saved, a drop-down should display the options.

Actual result:
- when there is just one login saved, the autocomplete works: username and pass are auto-filled in when you start the web app.
- when there are 2 or more logins saved for the same site, passwords are filled in but usernames not. You have to type in the username and then the password will be autocompleted. In the browser, there is a username drop-down list for auto-complete that doesn't appear in the web app.

note: The same issue occurs for custom tabs if you open the twitter login page(from a gmail link, for e.g.).

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Jim is everything in for this to work?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

We need a FormAssistPopup view in the WebAppActivity layout, which is currently just the GeckoView itself [1]. So basically, we need to add some kind of relative layout for WebAppActivity, and add [2] to that.

Nevin, can someone from frontend work on this?

[1] http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java#116
[2] http://searchfox.org/mozilla-central/rev/3dbb47302e114219c53e99ebaf50c5cb727358ab/mobile/android/app/src/main/res/layout/customtabs_activity.xml#30

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi Wesly, Joe
Please help prioritze this for FormAssistPopup support for PWA(GeckoView-based app)

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

is this part of the GeckoView feature offering?

Comment 5

[Wesly Huang (EPM)]

P2 for now, since same as Custom Tab that's already in 57, per comment 0.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Joe Cheng [:jcheng] (please needinfo) from comment #4)
> is this part of the GeckoView feature offering?

No, but there is some stuff to make it work in Custom Tabs. Comment #2 lists the steps the frontend needs to take to make it work in the PWA activity.

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1403566 - Support mutli login for PWA.

Review commit: https://reviewboard.mozilla.org/r/203442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203442/

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8932381 [details]
Bug 1403566 - Support mutli login for PWA.

https://reviewboard.mozilla.org/r/203442/#review208984

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f945ce89be8
Support mutli login for PWA. r=jchen

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5f945ce89be8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request?

Comment 12

[Nevin Chen(Not active on Bugzilla)]

Hi Wesly. Can we have QA verified first before we uplift? Or should we?

Comment 13

[Wesly Huang (EPM)]

Oana, Nevin had a patch to fix this one during some other tech. discussion. Would you help on the verification before we uplift it to Beta? Thanks!

Comment 14

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 59 (2017-12-05) for PWA and custom tabs.
Devices:
Samsung Galaxy Note 4 (Android 5.0.1)
LG Nexus 5 (Android 6.0.1)

Comment 15

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8932381 [details]
Bug 1403566 - Support mutli login for PWA.

Approval Request Comment
[Feature/Bug causing the regression]:PWA needs to display a list in Java UI when users have multiple login saved
[User impact if declined]: User won't see anything if they have more than one login saved
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: We just show extra UI. So it should be safe.
[String changes made/needed]: no

Comment 16

[Julien Cristau [:jcristau]]

I'm not sure I'm comfortable with "we just show extra UI" as risk assessment here.  We've had this bug on file for two months and it hasn't been a priority until now, why is it suddenly needed in late beta?

Comment 17

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/5f945ce89be85807d1f7e5f43424ab16ad1530f9
Bug 1403566 - Support mutli login for PWA. r=jchen

Comment 18

[Nevin Chen(Not active on Bugzilla)]

Just found out my reply is not saved! I thought I replied just after you posted ... sorry again.


(In reply to Julien Cristau [:jcristau] from comment #16)
> I'm not sure I'm comfortable with "we just show extra UI" as risk assessment
The reason I said it "just show extra UI" is because the same UI is displayed for custom tab (see comment 2) so it's nothing new.

> here.  We've had this bug on file for two months and it hasn't been a
> priority until now, why is it suddenly needed in late beta?

This is because we don't have the time and there's no plan to fix p2.(see  Comment 5)

> why is it suddenly needed in late beta? Cause 

We fix it now cuase we finaly have time for bugs other than p2 (see https://wiki.mozilla.org/Mobile/Firefox_for_Android, sprint 59.2)

I think Wesly can help elaberate more

Comment 19

[Gerry Chang [:gchang]]

Comment on attachment 8932381 [details]
Bug 1403566 - Support mutli login for PWA.

It's late beta. Might be a big risky to have this in beta. Beta58-.

Comment 20

[Wesly Huang (EPM)]

(In reply to Nevin Chen [:nechen](pto till Jan 3rd) from comment #18)
> (In reply to Julien Cristau [:jcristau] from comment #16)
> > why is it suddenly needed in late beta? Cause  
> We fix it now cuase we finaly have time for bugs other than p2 (see
> https://wiki.mozilla.org/Mobile/Firefox_for_Android, sprint 59.2)
> 
> I think Wesly can help elaberate more

Sorry for late. Indeed we plan to tackle this issue later so we didn't fix it in the 1st place. I can understand RM's concern as well, so let's live with it.