1403824 - Keep track of arenas in the arena tree

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1403824 - Keep track of arenas in the arena tree.

Bug 1402174 made all arenas registered in a Red-Black tree. Which means
they are iterable through that tree, making the arenas list now redundant.
The list is also inconvenient, since it needs to be constantly
reallocated, and the allocator in charge of the list doesn't know how to
free things.

Iteration of arenas is not on any hot path anyways, so even though
iterating the RB tree is slower, it doesn't matter.

So we remove the arenas list, and keep a direct pointer to the main
arena for convenience (instead of calling First() on the RB tree every
time)

Review commit: https://reviewboard.mozilla.org/r/184430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184430/

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8913046 [details]
Bug 1403824 - Keep track of arenas in the arena tree.

https://reviewboard.mozilla.org/r/184430/#review189598

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4db9dfba44d
Keep track of arenas in the arena tree. r=njn

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c4db9dfba44d