Closed
Bug 1403926
Opened 6 years ago
Closed 6 years ago
PerformanceNavigationTiming fields are not correct
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
The implementation we landed has several issues that were not detected by the web-platform tests: - Some of the timestamps were DOMTimeMilliSec instead of DOMHighResTimeStamp - The timestamps were absolute, rather than relative to startTime. - The PerformanceNavigationTiming entry should only be available after the page is fully loaded Apart from fixing the above problems, I indent to add a pref to disable this feature if needed.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8914999 [details] Bug 1403926 - Add pref for PerformanceNavigationTiming https://reviewboard.mozilla.org/r/186266/#review191344
Attachment #8914999 -
Flags: review?(amarchesini) → review+
|
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915000 [details] Bug 1403926 - Make the PerformanceNavigationTiming timestamps be relative to startTime https://reviewboard.mozilla.org/r/186268/#review191348
Attachment #8915000 -
Flags: review?(amarchesini) → review+
|
|
||
Comment 6•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8915001 [details] Bug 1403926 - Make sure PerformanceNavigationTiming timestamps are correct https://reviewboard.mozilla.org/r/186270/#review191352
Attachment #8915001 -
Flags: review?(amarchesini) → review+
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4af284ac9c15 Add pref for PerformanceNavigationTiming r=baku https://hg.mozilla.org/integration/autoland/rev/6df68b0f2c76 Make the PerformanceNavigationTiming timestamps be relative to startTime r=baku https://hg.mozilla.org/integration/autoland/rev/969c5b28ee16 Make sure PerformanceNavigationTiming timestamps are correct r=baku
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4af284ac9c15 https://hg.mozilla.org/mozilla-central/rev/6df68b0f2c76 https://hg.mozilla.org/mozilla-central/rev/969c5b28ee16
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 9•6 years ago
|
||
Docs need to ensure that the type changes are reflected, as well as the existence of the preference and its default status.
Keywords: dev-doc-needed
|
||
Comment 10•6 years ago
|
||
Most of the information on the ref pages seemed pretty much right, so I've only made a couple of small changes. However, I have added a section of notes to the main interface page, and to the Fx 58 rel notes to explain these changes: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceNavigationTiming#Gecko_notes https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM Does this sound OK?
Keywords: dev-doc-needed → dev-doc-complete
|
Assignee | |
Comment 11•6 years ago
|
||
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10) > Most of the information on the ref pages seemed pretty much right, so I've > only made a couple of small changes. However, I have added a section of > notes to the main interface page, and to the Fx 58 rel notes to explain > these changes: > > https://developer.mozilla.org/en-US/docs/Web/API/ > PerformanceNavigationTiming#Gecko_notes > https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM > > Does this sound OK? Since the bugs referenced by the first three bullet points were only live for a few weeks on Nightly, I don't think we need to mention the "improvements". The pref name is great to have in the docs. Thanks!
|
|
||
Comment 12•6 years ago
|
||
(In reply to Valentin Gosu [:valentin] from comment #11) > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10) > > Most of the information on the ref pages seemed pretty much right, so I've > > only made a couple of small changes. However, I have added a section of > > notes to the main interface page, and to the Fx 58 rel notes to explain > > these changes: > > > > https://developer.mozilla.org/en-US/docs/Web/API/ > > PerformanceNavigationTiming#Gecko_notes > > https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM > > > > Does this sound OK? > > Since the bugs referenced by the first three bullet points were only live > for a few weeks on Nightly, I don't think we need to mention the > "improvements". The pref name is great to have in the docs. > > Thanks! OK, no worries. I've updated the docs to just mention to pref.
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•