1403926 - PerformanceNavigationTiming fields are not correct

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Valentin Gosu [:valentin] (he/him)]

The implementation we landed has several issues that were not detected by the web-platform tests:

- Some of the timestamps were DOMTimeMilliSec instead of DOMHighResTimeStamp
- The timestamps were absolute, rather than relative to startTime.
- The PerformanceNavigationTiming entry should only be available after the page is fully loaded

Apart from fixing the above problems, I indent to add a pref to disable this feature if needed.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1403926 - Add pref for PerformanceNavigationTiming

Review commit: https://reviewboard.mozilla.org/r/186266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186266/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1403926 - Make the PerformanceNavigationTiming timestamps be relative to startTime

Review commit: https://reviewboard.mozilla.org/r/186268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186268/

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1403926 - Make sure PerformanceNavigationTiming timestamps are correct

Review commit: https://reviewboard.mozilla.org/r/186270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186270/

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8914999 [details]
Bug 1403926 - Add pref for PerformanceNavigationTiming

https://reviewboard.mozilla.org/r/186266/#review191344

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8915000 [details]
Bug 1403926 - Make the PerformanceNavigationTiming timestamps be relative to startTime

https://reviewboard.mozilla.org/r/186268/#review191348

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8915001 [details]
Bug 1403926 - Make sure PerformanceNavigationTiming timestamps are correct

https://reviewboard.mozilla.org/r/186270/#review191352

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4af284ac9c15
Add pref for PerformanceNavigationTiming r=baku
https://hg.mozilla.org/integration/autoland/rev/6df68b0f2c76
Make the PerformanceNavigationTiming timestamps be relative to startTime r=baku
https://hg.mozilla.org/integration/autoland/rev/969c5b28ee16
Make sure PerformanceNavigationTiming timestamps are correct r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4af284ac9c15
https://hg.mozilla.org/mozilla-central/rev/6df68b0f2c76
https://hg.mozilla.org/mozilla-central/rev/969c5b28ee16

Comment 9

[Eric Shepherd [:sheppy]]

Docs need to ensure that the type changes are reflected, as well as the existence of the preference and its default status.

Comment 10

[Chris Mills [:cmills]]

Most of the information on the ref pages seemed pretty much right, so I've only made a couple of small changes. However, I have added a section of notes to the main interface page, and to the Fx 58 rel notes to explain these changes:

https://developer.mozilla.org/en-US/docs/Web/API/PerformanceNavigationTiming#Gecko_notes
https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM

Does this sound OK?

Comment 11

[Valentin Gosu [:valentin] (he/him)]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> Most of the information on the ref pages seemed pretty much right, so I've
> only made a couple of small changes. However, I have added a section of
> notes to the main interface page, and to the Fx 58 rel notes to explain
> these changes:
> 
> https://developer.mozilla.org/en-US/docs/Web/API/
> PerformanceNavigationTiming#Gecko_notes
> https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM
> 
> Does this sound OK?

Since the bugs referenced by the first three bullet points were only live for a few weeks on Nightly, I don't think we need to mention the "improvements". The pref name is great to have in the docs.

Thanks!

Comment 12

[Chris Mills [:cmills]]

(In reply to Valentin Gosu [:valentin] from comment #11)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #10)
> > Most of the information on the ref pages seemed pretty much right, so I've
> > only made a couple of small changes. However, I have added a section of
> > notes to the main interface page, and to the Fx 58 rel notes to explain
> > these changes:
> > 
> > https://developer.mozilla.org/en-US/docs/Web/API/
> > PerformanceNavigationTiming#Gecko_notes
> > https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM
> > 
> > Does this sound OK?
> 
> Since the bugs referenced by the first three bullet points were only live
> for a few weeks on Nightly, I don't think we need to mention the
> "improvements". The pref name is great to have in the docs.
> 
> Thanks!

OK, no worries. I've updated the docs to just mention to pref.