Closed
Bug 140399
Opened 23 years ago
Closed 23 years ago
Do not define DEBUG_`whoami`
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: wtc, Assigned: wtc)
References
Details
Attachments
(1 file)
680 bytes,
patch
|
netscape
:
review+
|
Details | Diff | Splinter Review |
The DEBUG_`whoami` has been a porting problem. First, the
whoami command is not available on all platforms. Second,
on some platforms the user ids may contain non-alphanumeric
characters (such as space).
I propose that we not define the DEBUG_`whoami` macro. It
is not useful.
Assignee | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
Comment on attachment 81199 [details] [diff] [review]
Proposed patch. Do not define DEBUG_`whoami`.
Since no one checks debug code with the user specific ifdefs into NSPR,
removing the define here should be fine. r=cls
Attachment #81199 -
Flags: review+
Assignee | ||
Comment 3•23 years ago
|
||
Both of the problems with 'whoami' have been
addressed in bug 137059, so we can continue
to use it (on Unix).
Marked the bug WONTFIX.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•