137059 - configure outputs incorrect definition for DEFINES if whoami returns a name with a space

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P4)

Description

[Jonathan Wilson]

On my system, whoami (from cygwin) returns Jonathan Wilson
This causes something inside configure to define DEFINES as 
-DDEBUG_Jonathan=Wilson\ 1 (plus other defines).

Is this infact a problem with configure and if so, what do we do to fix it?

Comment 1

[hacker formerly known as [e-mail]]

This is questionably a problem with configure.  We don't support spaces in
usernames and that's what's causing whomai to return that bogus value.

Comment 2

[Jonathan Wilson]

Accepting this bug, fix should be available shortly

Comment 3

[Jonathan Wilson]

I got a fix for this bug available but I cant make a patch since my configure.in
files have changed because of bug 134113
You change line 323 of nsprpub/configure.in to this
    AC_DEFINE_UNQUOTED(DEBUG_`$WHOAMI | sed -e's/ /_/g;'`)
and line 3316 of configure.in to this
        MOZ_DEBUG_ENABLE_DEFS="$MOZ_DEBUG_ENABLE_DEFS -DDEBUG_`echo ${USERNAME}
| sed -e's/ /_/g;'`"

Anyone that has vanila configure.in files want to do the changes then post a fix
to the bug?

Comment 4

[David Bradley]

Attachment: Jonathan's patch

Comment 5

[David Bradley]

Attachment: Corrected patch

Comment 6

[Wan-Teh Chang]

I suggest that we simply not define the DEBUG_`$WHOAMI` macro.
This is what I will do to the NSPR build system (bug 140399).
In fact I doubt anyone is using the DEBUG_`$WHOAMI` macro now.

Comment 7

[hacker formerly known as [e-mail]]

Well, it's not used in NSPR but it is used all over the rest of the tree, as an
lxr for DEBUG_ will show (or DEBUG_<your favorite hacker here>).  I don't see
any benefit of dropping the define at this point. 

Comment 8

[Jesse Ruderman]

*** Bug 89302 has been marked as a duplicate of this bug. ***

Comment 9

[hacker formerly known as [e-mail]]

Attachment: drop whoami for win32 & fix ldap too

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 94527 [details] [diff] [review]
drop whoami for win32 & fix ldap too

r=[e-mail]

Comment 11

[Mark Smith [:mcs]]

Comment on attachment 94527 [details] [diff] [review]
drop whoami for win32 & fix ldap too

r=mcs

Comment 12

[hacker formerly known as [e-mail]]

The patch has been checked into:
mozilla trunk
nspr trunk
ldap trunk
nspr NSPRPUB_PRE_4_2_CLIENT_BRANCH
ldap ldapcsdk_50_client_branch

Comment 13

[Wan-Teh Chang]

Comment on attachment 94527 [details] [diff] [review]
drop whoami for win32 & fix ldap too

>+    case "${target_os}" in
>+    beos*)
>+        DEFINES="$DEFINES -DDEBUG_${USER}"
>+        ;;
>+    msvc*|mksnt*|cygwin*|mingw*)
>+        DEFINES="$DEFINES -DDEBUG_`echo ${USERNAME} | sed -e 's| |_|g'`"
>+        ;;
>+    *) 
>+        DEFINES="$MOZ_DEBUG_ENABLE_DEFS -DDEBUG_`$WHOAMI`"
>+        ;;
>+    esac

MOZ_DEBUG_ENABLE_DEFS is not defined in mozilla/nsprpub/configure.in.
Perhaps the code for the default case should say:
	  DEFINES="$DEFINES -DDEBUG_`$WHOAMI`"

Comment 14

[Roland Mainz]

Just wondering:
Why is "whoami" used at all ? AFAIK the ${LOGNAME} env variable provides the
same info...

Comment 15

[Wan-Teh Chang]

Comment on attachment 94527 [details] [diff] [review]
drop whoami for win32 & fix ldap too

In nsprpub/configure.in, I changed
	DEFINES="$MOZ_DEBUG_ENABLE_DEFS -DDEBUG_`$WHOAMI`"
to
	DEFINES="$DEFINES -DDEBUG_`$WHOAMI`"
on the tip and NSPRPUB_PRE_4_2_CLIENT_BRANCH of NSPR.

The same change needs to be made to directory/c-sdk/configure.in.

Comment 16

[Roland Mainz]

wtc:
Any idea why we use "whoami" and not $LOGNAME ?

Comment 17

[Wan-Teh Chang]

The use of "whoami" comes from the original
Netscape browser build system (ns/config/*.mk).
I don't know why it used "whoami", not $LOGNAME.

Comment 18

[Roland Mainz]

Wan-Teh Chang wrote:
> I don't know why it used "whoami", not $LOGNAME

What about killing all the "whoami" stuff and simply use $LOGNAME instead ?

Comment 19

[hacker formerly known as [e-mail]]

FWIW, $LOGNAME is not universal either.  LOGNAME is not set when using the BeOS
version of bash.  $USER is as close as you'll get to having universal coverage
afaict and even that's not set by win32's cmd.exe.