###!!! ASSERTION: The context of the current AzureState is not altered after Save() been called when using certificate viewer

RESOLVED FIXED in Firefox 58

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: keeler, Assigned: u459114)

Tracking

unspecified
mozilla58
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional, firefox58 fixed)

Details

Attachments

(1 attachment)

STR: run a debug build of Firefox from a terminal, visit an https website (e.g. https://google.com). Click the lock -> right arrow -> "More Information" -> Security -> View Certificate -> Details

Results: a ton of these in the terminal:
[Parent 19714, Main Thread] ###!!! ASSERTION: The context of the current AzureState is not altered after Save() been called. you may consider to remove this pair of gfxContext::Save/Restore.: 'CurrentState().mContentChanged || CurrentState().pushedClips.Length() > 0', file mozilla-unified/gfx/thebes/gfxContext.cpp, line 184
CJ, this is a regression from bug 1385929.  I don't know the consequences, so setting as P1 "must fix for 57", but feel free to change that if the implications of this assert are less than what I thought.
Blocks: 1385929
status-firefox57: --- → affected
status-firefox58: --- → affected
Component: Graphics → Layout: Web Painting
Flags: needinfo?(matt.woodrow)
Flags: needinfo?(cku)
Priority: -- → P1
This assertion is just a performance warning, so definitely not critical and shouldn't be P1 (imo).
Flags: needinfo?(matt.woodrow)
(Assignee)

Updated

2 years ago
Assignee: nobody → cku
Flags: needinfo?(cku)
(Assignee)

Updated

2 years ago
status-firefox57: affected → fix-optional
Priority: P1 → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8914157 - Flags: review?(matt.woodrow)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8914157 [details]
Bug 1404077 - Remove unnecessary gfxContext::Save/Load in nsTreeBodyFrame::PaintCell.

https://reviewboard.mozilla.org/r/185480/#review190486
Attachment #8914157 - Flags: review?(matt.woodrow) → review+

Comment 6

2 years ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d64a80863e71
Remove unnecessary gfxContext::Save/Load in nsTreeBodyFrame::PaintCell. r=mattwoodrow

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d64a80863e71
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.