1404189 - fsanitize=enum (ubsan) runtime errors in js/src/jit/RegisterSets.h

Status: RESOLVED DUPLICATE of bug 1404251

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Arthur Edelstein [:arthur]]

When I run mozilla-central's automated tests with fsanitize=enum, I get errors like the following:
js/src/jit/RegisterSets.h:1378:9: runtime error: load of value 4294967295, which is not a valid value for type 'Kind'

An ABIArg::Kind enum is being initialized to -1 even though that is not an allowed value.

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1404189-Fix-ubsan-runtime-error-for-ABIArg-Kind-.patch

Here's a proposed patch that suppresses the ubsan runtime error.

try server: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a91637e0710c

Comment 2

[Arthur Edelstein [:arthur]]

Comment on attachment 8913541 [details] [diff] [review]
0001-Bug-1404189-Fix-ubsan-runtime-error-for-ABIArg-Kind-.patch

Review of attachment 8913541 [details] [diff] [review]:
-----------------------------------------------------------------

(I need to fix an error in the patch.)

Comment 3

[André Bargull [:anba]]

(In reply to Arthur Edelstein (Tor Browser dev) [:arthuredelstein] from comment #2)
> (I need to fix an error in the patch.)

I guess the missing |default| cases in switch-statements? Been there, done that: https://hg.mozilla.org/try/rev/6ecaee02e534c217fcaa5f07db72172bea5dd5df :-)

(I have a not yet published queue which should fix most UBSan issues in SpiderMonkey: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5014dec2f36c49fc079d6b1bf2714d8d1aae6cb2)

Comment 4

[Arthur Edelstein [:arthur]]

(In reply to André Bargull [:anba] from comment #3)
> (In reply to Arthur Edelstein (Tor Browser dev) [:arthuredelstein] from
> comment #2)
> > (I need to fix an error in the patch.)
> 
> I guess the missing |default| cases in switch-statements? Been there, done
> that:
> https://hg.mozilla.org/try/rev/6ecaee02e534c217fcaa5f07db72172bea5dd5df :-)

Yeah, exactly. Do you want to push your patch forward at this point?

> (I have a not yet published queue which should fix most UBSan issues in
> SpiderMonkey:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=5014dec2f36c49fc079d6b1bf2714d8d1aae6cb2)

Nice!

Comment 5

[André Bargull [:anba]]

Fixed in bug 1404251, along some other UBSan issues.