1404224 - fsanitize=enum (ubsan) runtime errors for nsCSSTokenSerializationType

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Arthur Edelstein [:arthur]]

Running automated tests with fsanitize=enum results in errors like:

> [task 2017-09-25T00:48:33.567Z] 00:48:33     INFO - REFTEST INFO | SET PREFERENCE pref(layout.css.servo.enabled,false)
> [task 2017-09-25T00:48:33.567Z] 00:48:33     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-48.html | 1929 / 1937 (99%)
> [task 2017-09-25T00:48:33.588Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableResolver.cpp:157:40: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType'
> [task 2017-09-25T00:48:33.589Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableResolver.cpp:157:40: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType'
> [task 2017-09-25T00:48:33.590Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.h:105:10: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType'
> [task 2017-09-25T00:48:33.591Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.h:105:10: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType'
> [task 2017-09-25T00:48:33.591Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.cpp:95:32: runtime error: load of value 3506570800, which is not a valid value for type 'nsCSSTokenSerializationType'
> [task 2017-09-25T00:48:33.592Z] 00:48:33     INFO - /builds/worker/workspace/build/src/layout/style/CSSVariableValues.cpp:96:31: runtime error: load of value 32765, which is not a valid value for type 'nsCSSTokenSerializationType'

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-1404224-Fix-ubsan-runtime-error-for-nsCSSTokenSe.patch

Here's a patch that fixes the runtime errors.

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b89c25622003&selectedJob=134579805
(Patch is 4th commit from top. Bad Talos results are presumably unrelated.)

Comment 2

[Arthur Edelstein [:arthur]]

Thanks for the review.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/30a40b41d590
Fix ubsan runtime error for nsCSSTokenSerializationType. r=heycam

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/30a40b41d590