Open Bug 1404237 Opened 2 years ago Updated 2 years ago

Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

ASSIGNED
Tracking Status
firefox57 --- wontfix

People

(Reporter: lvk, Assigned: lvk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Blocker/sub-bug for bug #1277133.

The plan is to change the NS_STYLE_DISPLAY_MODE_* constants (http://searchfox.org/mozilla-central/source/layout/style/nsStyleConsts.h#1208-1211) to an enum class called StyleDisplayMode, updating any uses. These constants are only used in a few places each, so this should be a quick fix.
"blocker" means different thing.
if this bug blocks another bug, you need to add the bug number to "blocks" field ;)
Blocks: 1277133
Severity: blocker → normal
Status: UNCONFIRMED → NEW
Component: Untriaged → CSS Parsing and Computation
Ever confirmed: true
Product: Firefox → Core
(In reply to Tooru Fujisawa [:arai] from comment #1)
> "blocker" means different thing.
> if this bug blocks another bug, you need to add the bug number to "blocks"
> field ;)

Thanks! Could you assign the bug to me?
Flags: needinfo?(arai.unmht)
Assignee: nobody → lkhodel
Status: NEW → ASSIGNED
Flags: needinfo?(arai.unmht)
Priority: -- → P3
Attachment #8915367 - Flags: review?(manishearth)
Comment on attachment 8915367 [details]
Bug 1404237: Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode.

https://reviewboard.mozilla.org/r/186562/#review196974
Attachment #8915367 - Flags: review?(manishearth) → review+
Comment on attachment 8915367 [details]
Bug 1404237: Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode.

https://reviewboard.mozilla.org/r/186562/#review196976

::: layout/style/nsMediaFeatures.cpp:345
(Diff revision 1)
> -                nsIDocShell::DISPLAY_MODE_FULLSCREEN == NS_STYLE_DISPLAY_MODE_FULLSCREEN,
> -                "nsIDocShell display modes must mach nsStyleConsts.h");
> +                nsIDocShell::DISPLAY_MODE_FULLSCREEN == static_cast<uint32_t>(StyleDisplayMode::Fullscreen),
> +                "nsIDocShell display modes must match nsStyleConsts.h");
>  
> -  uint32_t displayMode = NS_STYLE_DISPLAY_MODE_BROWSER;
> +  uint32_t displayMode = static_cast<uint32_t>(StyleDisplayMode::Browser);
>    if (docShell) {
>      docShell->GetDisplayMode(&displayMode);

GetDisplayMode and if it exists SetDisplayMode should both take StyleDisplayMode as arguments now
You need to log in before you can comment on or make changes to this bug.