1404237 - Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode

Status: RESOLVED DUPLICATE of bug 1481961

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Leo Khodel [:lvk]]

Blocker/sub-bug for bug #1277133.

The plan is to change the NS_STYLE_DISPLAY_MODE_* constants (http://searchfox.org/mozilla-central/source/layout/style/nsStyleConsts.h#1208-1211) to an enum class called StyleDisplayMode, updating any uses. These constants are only used in a few places each, so this should be a quick fix.

Comment 1

[Tooru Fujisawa [:arai]]

"blocker" means different thing.
if this bug blocks another bug, you need to add the bug number to "blocks" field ;)

Comment 2

[Leo Khodel [:lvk]]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> "blocker" means different thing.
> if this bug blocks another bug, you need to add the bug number to "blocks"
> field ;)

Thanks! Could you assign the bug to me?

Comment 3

[Leo Khodel [:lvk]]

Attachment: Bug 1404237: Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode.

Review commit: https://reviewboard.mozilla.org/r/186562/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186562/

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8915367 [details]
Bug 1404237: Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode.

https://reviewboard.mozilla.org/r/186562/#review196974

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8915367 [details]
Bug 1404237: Replace NS_STYLE_DISPLAY_MODE_* consts with enum class StyleDisplayMode.

https://reviewboard.mozilla.org/r/186562/#review196976

::: layout/style/nsMediaFeatures.cpp:345
(Diff revision 1)
> -                nsIDocShell::DISPLAY_MODE_FULLSCREEN == NS_STYLE_DISPLAY_MODE_FULLSCREEN,
> -                "nsIDocShell display modes must mach nsStyleConsts.h");
> +                nsIDocShell::DISPLAY_MODE_FULLSCREEN == static_cast<uint32_t>(StyleDisplayMode::Fullscreen),
> +                "nsIDocShell display modes must match nsStyleConsts.h");
>  
> -  uint32_t displayMode = NS_STYLE_DISPLAY_MODE_BROWSER;
> +  uint32_t displayMode = static_cast<uint32_t>(StyleDisplayMode::Browser);
>    if (docShell) {
>      docShell->GetDisplayMode(&displayMode);

GetDisplayMode and if it exists SetDisplayMode should both take StyleDisplayMode as arguments now

Comment 6

[Emilio Cobos Álvarez [:emilio]]

This one was done in bug 1481961.