Closed
Bug 1481961
Opened 6 years ago
Closed 6 years ago
Refactor media queries so that multiple keywords can match a query.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(1 file)
This also allows to share almost all the media query code with Servo, which is neat.
|
Assignee | |
Comment 1•6 years ago
|
||
This allows the use case from evaluation media queries, moves most of the code to be Rust, except potentially some evaluator functions, and finally allows to unblock the use case from any-hover / any-pointer and remove nsMediaFeatures. I've only ported width / height / orientation, but they work and is probably a good skim at how it could work.
|
||
Updated•6 years ago
|
Attachment #8998666 -
Attachment description: WIP: Rewrite media queries so that they work on an evaluator function. → Rewrite media queries so that they work on an evaluator function.
|
||
Updated•6 years ago
|
Priority: -- → P3
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8998666 [details]
Rewrite media queries so that they work on an evaluator function.
Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #8998666 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/0214ed222b79 Rewrite media queries so that they work on an evaluator function. r=xidorn https://hg.mozilla.org/integration/mozilla-inbound/rev/f65812990b76 Revendor Rust dependencies. r=me
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0214ed222b79 https://hg.mozilla.org/mozilla-central/rev/f65812990b76
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•