Refactor media queries so that multiple keywords can match a query.

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P3
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

11 months ago
This also allows to share almost all the media query code with Servo, which is neat.
Assignee

Comment 1

11 months ago
This allows the use case from evaluation media queries, moves most of
the code to be Rust, except potentially some evaluator functions, and finally
allows to unblock the use case from any-hover / any-pointer and remove
nsMediaFeatures.

I've only ported width / height / orientation, but they work and is probably a
good skim at how it could work.

Updated

11 months ago
Attachment #8998666 - Attachment description: WIP: Rewrite media queries so that they work on an evaluator function. → Rewrite media queries so that they work on an evaluator function.

Updated

11 months ago
Priority: -- → P3
Blocks: 1483111
No longer blocks: 1035774
Comment on attachment 8998666 [details]
Rewrite media queries so that they work on an evaluator function.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #8998666 - Flags: review+

Comment 3

11 months ago
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0214ed222b79
Rewrite media queries so that they work on an evaluator function. r=xidorn
https://hg.mozilla.org/integration/mozilla-inbound/rev/f65812990b76
Revendor Rust dependencies. r=me

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0214ed222b79
https://hg.mozilla.org/mozilla-central/rev/f65812990b76
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.