1404311 - PWAs and Custom Tabs can't be debugged through WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, enhancement, P3)

Description

[Andreas Bovens [:abovens]]

It appears like PWAs (when running in standalone/fullscreen mode) and Custom Tabs don't show up in WebIDE and thus cannot be debugged. 

This doesn't present a big problem for Custom Tabs (the page in question can be reloaded in a normal tab and debugged), although it would be nice if it would work of course; however, in the case of PWAs, there might be viewmode-specific layout or behavior, and thus being able to debug an installed PWA would certainly be valuable.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Eugen I think maybe we just need to make the devtools look for navigator:geckoview by default?

Comment 2

[Dietrich Ayala (:dietrich)]

See bug 1314811, where WebIDE is being removed, and bug 1212802 where remote debugging of these things will be in about:debugging.

Comment 3

[Eugen Sawin [:esawin]]

In bug 1401002 we've added USB-debugging support for GeckoView-based apps.
Currently, GeckoViewSettings.USE_REMOTE_DEBUGGER defaults to false for Fennec (custom tabs, PWAs) and is controlled via the intent extra use_remote_debugger for geckoview_example.

(In reply to James Willcox (:snorp) ([e-mail]) from comment #1)
> Eugen I think maybe we just need to make the devtools look for
> navigator:geckoview by default?

I'm not sure why that would be required.
However, we should probably link Fennec's remote debugging pref to GeckoView's setting to enable debugging for custom tabs and PWAs.

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1404311-1.0-Enable-remote-USB-debugging-of-custo.patch

Fennec should control whether its GeckoView-based custom tabs and PWAs should be remote-debuggable.

Note: currently only USB-debugging is supported in GeckoView.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8914516 [details] [diff] [review]
0001-Bug-1404311-1.0-Enable-remote-USB-debugging-of-custo.patch

Review of attachment 8914516 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/LauncherActivity.java
@@ +150,5 @@
>      }
>  
> +    private boolean isRemoteDebuggingEnabled() {
> +        return GeckoSharedPrefs.forApp(this).getBoolean(
> +                   GeckoPreferences.PREFS_DEVTOOLS_REMOTE_USB_ENABLED, false);

Drive-by: Any reason for going through LauncherActivity? I think it'd be easier to just check for this pref inside CustomTabsActivity or WebAppActivity.

Comment 6

[Eugen Sawin [:esawin]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #5)
> Drive-by: Any reason for going through LauncherActivity? I think it'd be
> easier to just check for this pref inside CustomTabsActivity or
> WebAppActivity.

The idea was to provide a uniform intent-based interface for {GeckoView, WebApp, CustomTabs}Activity without introducing strong coupling to Gecko/Fennec (prefs) within the activities.
Do you see a disadvantage with that?

Comment 7

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1404311-1.1-Enable-remote-USB-debugging-of-custo.patch

Move pref checking out of LauncherActivity.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/726d74704ad6
[1.1] Enable  remote USB debugging of custom tabs and PWAs through Fennec settings. r=snorp

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/726d74704ad6