Closed Bug 1404359 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox60 fixed)

RESOLVED FIXED
Firefox 60
Tracking Status
firefox60 --- fixed

People

(Reporter: nchevobbe, Assigned: miker)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → mratcliffe
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → All
Priority: P2 → P1
Hardware: Unspecified → All
Status: NEW → ASSIGNED
Comment on attachment 8950403 [details]
Bug 1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

https://reviewboard.mozilla.org/r/219624/#review225414

looks good to me, let's just see if we need a followup for the weird focus issue you highlighted.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_select_all.js:42
(Diff revision 1)
> +  // The focus is on the JsTerm, so we need to blur it for the copy comand to
> +  // work.

Check with Nicolas if we want to improve the behavior of the select all menu item in a follow up, and if yes, mention it here?

nit: comand -> command
Attachment #8950403 - Flags: review?(jdescottes) → review+
Comment on attachment 8950403 [details]
Bug 1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

https://reviewboard.mozilla.org/r/219624/#review225498

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_select_all.js:42
(Diff revision 1)
> +  // The focus is on the JsTerm, so we need to blur it for the copy comand to
> +  // work.

nchevobbe said we should create helpers for this and update existing tests. Logged bug 1437802.
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b61c885acf48
Migrate browser_webconsole_bug_586388_select_all.js to the new frontend r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/b61c885acf48
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.