1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

Review commit: https://reviewboard.mozilla.org/r/219624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/219624/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8950403 [details]
Bug 1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

https://reviewboard.mozilla.org/r/219624/#review225414

looks good to me, let's just see if we need a followup for the weird focus issue you highlighted.

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_select_all.js:42
(Diff revision 1)
> +  // The focus is on the JsTerm, so we need to blur it for the copy comand to
> +  // work.

Check with Nicolas if we want to improve the behavior of the select all menu item in a follow up, and if yes, mention it here?

nit: comand -> command

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8950403 [details]
Bug 1404359 - Migrate browser_webconsole_bug_586388_select_all.js to the new frontend

https://reviewboard.mozilla.org/r/219624/#review225498

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_select_all.js:42
(Diff revision 1)
> +  // The focus is on the JsTerm, so we need to blur it for the copy comand to
> +  // work.

nchevobbe said we should create helpers for this and update existing tests. Logged bug 1437802.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b61c885acf48
Migrate browser_webconsole_bug_586388_select_all.js to the new frontend r=jdescottes

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b61c885acf48