1404364 - Migrate browser_webconsole_bug_587617_output_copy.js to the new frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Only the first test case (http://searchfox.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_587617_output_copy.js#34-72) should be copied to the new frontend, since we already test the context menu entry in the new frontend.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

The part on the copy context menu was removed since we have a dedicated test
for that.
We also delete browser_webconsole_jsterm_copy.js which was doing the same thing.

Review commit: https://reviewboard.mozilla.org/r/218698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/218698/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8949316 [details]
Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

https://reviewboard.mozilla.org/r/218698/#review224498

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy.js:5
(Diff revision 1)
>  /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
>  /* vim: set ft=javascript ts=2 et sw=2 tw=80: */
>  /* Any copyright is dedicated to the Public Domain.
>   * http://creativecommons.org/publicdomain/zero/1.0/ */
>  /* globals goUpdateCommand goDoCommand */

goUpdateCommand no longer used here. (and I'm not sure goDoCommand is needed for eslint here, but can't tell where it's defined so might be better to keep here).

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_output_copy.js:23
(Diff revision 1)
> -    }, deferred.resolve, deferred.resolve);
>    });
> -  return deferred.promise;
> -}
> +  const {node} = await onMessage;
> +  ok(true, "Message was logged");
>  
> -// Test that the context menu "Copy" (which has a different code path) works
> +  const selection = node.ownerDocument.getSelection()

eslint: missing semi

Comment 4

[Julian Descottes [:jdescottes]]

Looks good! Nice catch about the duplicated test.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949316 [details]
Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218698/diff/1-2/

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949316 [details]
Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

https://reviewboard.mozilla.org/r/218698/#review224498

> goUpdateCommand no longer used here. (and I'm not sure goDoCommand is needed for eslint here, but can't tell where it's defined so might be better to keep here).

yep, it can be removed

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the review Julian. I updated the review to fix the eslint issues.

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 8de2bb92c44d4e7f05147dc63efac5263cafc398 -d 46c758115832: rebasing 446437:8de2bb92c44d "Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; r=jdescottes." (tip)
merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
warning: conflicts while merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949316 [details]
Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218698/diff/2-3/

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 23373397359cbea7af9f22b1e2163ee00765c6c5 -d dfd0afe71bb5: rebasing 446519:23373397359c "Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; r=jdescottes." (tip)
merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
warning: conflicts while merging devtools/client/webconsole/new-console-output/test/mochitest/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8949316 [details]
Bug 1404364 - Enable browser_webconsole_output_copy.js in new console frontend; .

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/218698/diff/3-4/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67200889cdc1
Enable browser_webconsole_output_copy.js in new console frontend; r=jdescottes.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/67200889cdc1