1404366 - Favicon.ico pink rendering

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Daniele "Mte90" Scasciafratte]

Attachment: wrong colors

When you open the website http://www.dati.gov.it/ and switch the tabs (when you are in that tab the colors are right) you can see that the icon is blinking in pink and next in white colors.

The icon link http://www.dati.gov.it/sites/default/files/datigovit_0.ico

Probably is the theme that I am using that alter the icon? As I can see when I hover the tab the image became with a white background but when I am in the tab the colors are right.

Comment 1

[Daniele "Mte90" Scasciafratte]

Attachment: correct.png

This should be the real colors

Comment 2

[Daniele "Mte90" Scasciafratte]

As I can see on Developer edition (57) switch only to pink while on nightly (58) there is the white blink.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Daniele "Mte90" Scasciafratte from comment #0)
> Probably is the theme that I am using that alter the icon? As I can see when
> I hover the tab the image became with a white background but when I am in
> the tab the colors are right.

Hi Daniele, I can reproduce the same bug in Nightly with the default theme, thus it's not your theme.
This is puzzling... Also opening just the icon link in comment 0 shows it.
The tabbed browser favicon code only sets the image attribute, so here looks like something may be wrong at a graphics/imageLib/layout level. It seems to happen when we apply the tab hover attribute.

Comment 4

[Marco Bonardo [:mak]]

The problem goes away commenting out any of these rules

.tab-line:not([selected=true]) {
  opacity: 0;
  transform: scaleX(0);
  transition: transform 250ms var(--animation-easing-function), opacity 250ms var(--animation-easing-function);
}

.tabbrowser-tab:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]) {
  background-color: rgba(0,0,0,.2);
  opacity: 1;
  transform: none;
}

Dao, any idea?

Comment 5

[Marco Bonardo [:mak]]

also ni Milan, since it honestly looks like something related to graphics or layers composition. But I'm really guessing.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] from comment #4)
> The problem goes away commenting out any of these rules
> 
> .tab-line:not([selected=true]) {
>   opacity: 0;
>   transform: scaleX(0);
>   transition: transform 250ms var(--animation-easing-function), opacity
> 250ms var(--animation-easing-function);
> }
> 
> .tabbrowser-tab:hover > .tab-stack > .tab-background >
> .tab-line:not([selected=true]) {
>   background-color: rgba(0,0,0,.2);
>   opacity: 1;
>   transform: none;
> }
> 
> Dao, any idea?

Just like bug 1401122 comment 15. Something very weird is going on on the Gecko side.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, Andrew has looked at this a bit, and can continue - bug 1401122 comment 17 may help triaging this.

Comment 8

[Jet Villegas (inactive)]

I posted two versions of this page to show the difference in favicon handing between ICO and PNG files:

http://media.junglecode.net/test/1404366/datigovit_0.png.html
http://media.junglecode.net/test/1404366/datigovit_0.ico.html

Note the masking and color glitches only on the ICO version. These errors don't appear on high-res displays or when image.downscale-during-decode.enabled is set to false.

Comment 9

[Jet Villegas (inactive)]

I'm moving this to ImgLib as it's clearly a BMP decoding/downscaling bug as indicated in comment 8.

Comment 10

[Milan Sreckovic [:milan] (needinfo for best results)]

Timothy is already looking at this.

Comment 11

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 12

[Daniele "Mte90" Scasciafratte]

Checking now the icon doesn't became anymore pink but only transparent/white on switching of tabs.

Comment 13

[Dão Gottwald [:dao]]

Is this patch ready to land?

Comment 14

[Timothy Nikkel (:tnikkel)]

I spent some time creating a test for this and finding more bugs. I have it working now, I just have to package the test and land.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bba778f860d2
Convert the image data for BMPs inside ICOs that has a mask to premultiplied alpha as expected. r=aosmond

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bba778f860d2