Closed
Bug 1404366
Opened 7 years ago
Closed 7 years ago
Favicon.ico pink rendering
Categories
(Core :: Graphics: ImageLib, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: mte90net, Assigned: tnikkel)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
When you open the website http://www.dati.gov.it/ and switch the tabs (when you are in that tab the colors are right) you can see that the icon is blinking in pink and next in white colors.
The icon link http://www.dati.gov.it/sites/default/files/datigovit_0.ico
Probably is the theme that I am using that alter the icon? As I can see when I hover the tab the image became with a white background but when I am in the tab the colors are right.
Reporter | ||
Comment 1•7 years ago
|
||
This should be the real colors
Reporter | ||
Comment 2•7 years ago
|
||
As I can see on Developer edition (57) switch only to pink while on nightly (58) there is the white blink.
Comment 3•7 years ago
|
||
(In reply to Daniele "Mte90" Scasciafratte from comment #0)
> Probably is the theme that I am using that alter the icon? As I can see when
> I hover the tab the image became with a white background but when I am in
> the tab the colors are right.
Hi Daniele, I can reproduce the same bug in Nightly with the default theme, thus it's not your theme.
This is puzzling... Also opening just the icon link in comment 0 shows it.
The tabbed browser favicon code only sets the image attribute, so here looks like something may be wrong at a graphics/imageLib/layout level. It seems to happen when we apply the tab hover attribute.
Comment 4•7 years ago
|
||
The problem goes away commenting out any of these rules
.tab-line:not([selected=true]) {
opacity: 0;
transform: scaleX(0);
transition: transform 250ms var(--animation-easing-function), opacity 250ms var(--animation-easing-function);
}
.tabbrowser-tab:hover > .tab-stack > .tab-background > .tab-line:not([selected=true]) {
background-color: rgba(0,0,0,.2);
opacity: 1;
transform: none;
}
Dao, any idea?
Flags: needinfo?(dao+bmo)
Comment 5•7 years ago
|
||
also ni Milan, since it honestly looks like something related to graphics or layers composition. But I'm really guessing.
Flags: needinfo?(milan)
Comment 6•7 years ago
|
||
(In reply to Marco Bonardo [::mak] from comment #4)
> The problem goes away commenting out any of these rules
>
> .tab-line:not([selected=true]) {
> opacity: 0;
> transform: scaleX(0);
> transition: transform 250ms var(--animation-easing-function), opacity
> 250ms var(--animation-easing-function);
> }
>
> .tabbrowser-tab:hover > .tab-stack > .tab-background >
> .tab-line:not([selected=true]) {
> background-color: rgba(0,0,0,.2);
> opacity: 1;
> transform: none;
> }
>
> Dao, any idea?
Just like bug 1401122 comment 15. Something very weird is going on on the Gecko side.
Yes, Andrew has looked at this a bit, and can continue - bug 1401122 comment 17 may help triaging this.
Flags: needinfo?(milan) → needinfo?(aosmond)
Updated•7 years ago
|
Component: Tabbed Browser → Layout
Product: Firefox → Core
Comment 8•7 years ago
|
||
I posted two versions of this page to show the difference in favicon handing between ICO and PNG files:
http://media.junglecode.net/test/1404366/datigovit_0.png.html
http://media.junglecode.net/test/1404366/datigovit_0.ico.html
Note the masking and color glitches only on the ICO version. These errors don't appear on high-res displays or when image.downscale-during-decode.enabled is set to false.
Component: Layout → Layout: Images
Comment 9•7 years ago
|
||
I'm moving this to ImgLib as it's clearly a BMP decoding/downscaling bug as indicated in comment 8.
Component: Layout: Images → ImageLib
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
status-firefox58:
--- → fix-optional
Priority: -- → P3
Whiteboard: [gfx-noted]
Timothy is already looking at this.
Flags: needinfo?(aosmond) → needinfo?(tnikkel)
Assignee | ||
Comment 11•7 years ago
|
||
Updated•7 years ago
|
Attachment #8922612 -
Flags: review?(aosmond) → review+
Reporter | ||
Comment 12•7 years ago
|
||
Checking now the icon doesn't became anymore pink but only transparent/white on switching of tabs.
Assignee | ||
Comment 14•7 years ago
|
||
I spent some time creating a test for this and finding more bugs. I have it working now, I just have to package the test and land.
Comment 15•7 years ago
|
||
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bba778f860d2
Convert the image data for BMPs inside ICOs that has a mask to premultiplied alpha as expected. r=aosmond
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(tnikkel)
Comment 16•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
QA Whiteboard: [good first verify]
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•