deprecation warning of encodeMimePartIIStr_UTF8 when parsing a non-UTF-8 encoded message subject

RESOLVED FIXED in Thunderbird 60.0

Status

defect
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 60.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
There is still some caller of encodeMimePartIIStr_UTF8() that passes in a non-UTF-8 charset argument:

DEPRECATION WARNING: Encoding to non-UTF-8 values is obsolete
You may find more details about this deprecation at: http://bugzilla.mozilla.org/show_bug.cgi?id=790855
file:///tbird-bin/dist/bin/components/mimeJSComponents.js 443 encodeMimePartIIStr_UTF8
1 Deprecated.jsm:79
warning resource://gre/modules/Deprecated.jsm:79:5
encodeMimePartIIStr_UTF8 file:///tbird-bin/dist/bin/components/mimeJSComponents.js:443:7

I traced it to https://dxr.mozilla.org/comm-central/rev/3dfe0c40ba28093a2c4638126fd1df3bb204561d/mailnews/base/util/nsMsgUtils.cpp#722
which is run when a message with non-UTF-8 charset encoded subject is first parsed.
Assignee

Comment 1

2 years ago
Posted patch 1404657.patchSplinter Review
Attachment #8914016 - Flags: review?(Pidgeot18)
Assignee

Comment 2

2 years ago
Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

Review of attachment 8914016 [details] [diff] [review]:
-----------------------------------------------------------------

I have tested this that there is no message with this patch and the subject is correctly displayed and also searching by the subject (with accented chars) works via quick filter bar.

Comment 3

2 years ago
Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

;-)
Attachment #8914016 - Flags: feedback+
Assignee

Updated

2 years ago
See Also: → 1412378
Assignee

Updated

2 years ago
Blocks: 1412574

Comment 4

a year ago
Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

Time to move this forward.
Attachment #8914016 - Flags: review?(Pidgeot18) → review+
Assignee

Comment 5

a year ago
The discussion of this fix can be found in the IRC logs of #maildev from 23rd Sep 2017.
Assignee

Comment 6

a year ago
Thanks.
Keywords: checkin-needed

Comment 7

a year ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/be57cca86031
encode message subject to UTF-8 in nsMsgUtils.cpp::NS_MsgStripRE. r=jorgk
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

a year ago
Target Milestone: --- → Thunderbird 60.0
You need to log in before you can comment on or make changes to this bug.