1404657 - deprecation warning of encodeMimePartIIStr_UTF8 when parsing a non-UTF-8 encoded message subject

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

There is still some caller of encodeMimePartIIStr_UTF8() that passes in a non-UTF-8 charset argument:

DEPRECATION WARNING: Encoding to non-UTF-8 values is obsolete
You may find more details about this deprecation at: http://bugzilla.mozilla.org/show_bug.cgi?id=790855
file:///tbird-bin/dist/bin/components/mimeJSComponents.js 443 encodeMimePartIIStr_UTF8
1 Deprecated.jsm:79
warning resource://gre/modules/Deprecated.jsm:79:5
encodeMimePartIIStr_UTF8 file:///tbird-bin/dist/bin/components/mimeJSComponents.js:443:7

I traced it to https://dxr.mozilla.org/comm-central/rev/3dfe0c40ba28093a2c4638126fd1df3bb204561d/mailnews/base/util/nsMsgUtils.cpp#722
which is run when a message with non-UTF-8 charset encoded subject is first parsed.

Comment 1

[:aceman]

Attachment: 1404657.patch

Comment 2

[:aceman]

Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

Review of attachment 8914016 [details] [diff] [review]:
-----------------------------------------------------------------

I have tested this that there is no message with this patch and the subject is correctly displayed and also searching by the subject (with accented chars) works via quick filter bar.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

;-)

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8914016 [details] [diff] [review]
1404657.patch

Time to move this forward.

Comment 5

[:aceman]

The discussion of this fix can be found in the IRC logs of #maildev from 23rd Sep 2017.

Comment 6

[:aceman]

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/be57cca86031
encode message subject to UTF-8 in nsMsgUtils.cpp::NS_MsgStripRE. r=jorgk