140466 - add help button to Page Info tabs

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P2)

Description

[Sean Cotter]

Some of the Page Info tabs display arcane information that is not yet documented
anywhere in the Help system. We should provide context-sensitive help and
appropriate search tags, at a minimum.

Implement a single help button across all Page Info tabs that figures out which
tab it's clicked in and opens the Help viewer to the following targets, as
appropriate:

pageinfo_general
pageinfo_forms
pageinfo_links
pageinfo_media
pageinfo_security

Help content for the equivalent sections is in progress.

Comment 1

[Sean Cotter]

nominating for nsbeta1+.

Comment 2

[rudman]

Nomination is "nsbeta1," and plussing done by component mgr. But I'll leave the
+, since this obviously needs it.

Adding impact for RTM. A nice-to-have for beta, but too late for that now. Let's
get it in for rtm.

Comment 3

[Ian Oeschger (gone)]

Accepting.

Comment 4

[Ian Oeschger (gone)]

Attachment: patch for adding Help button to Page Info dlog

Comment 5

[Ian Oeschger (gone)]

Attachment: picture of updated dialog

Comment 6

[racham]

Comment on attachment 83124 [details] [diff] [review]
patch for adding Help button to Page Info dlog

One modification that will be useful is to change 

+  width="425" height="470"

to something like 

+  width="&pageInfoWindow.width;" height="&pageInfoWindow.height;"

then add corresponding entries in pageInfo.dtd like

+<!ENTITY  pageInfoWindow.width 	   "425">
+<!ENTITY  pageInfoWindow.height	    "470">

After the change, please open the dialog again to make sure that the change is
effective.

Please incorporate the above. r=bhuvan.

Comment 7

[Ian Oeschger (gone)]

Bhuvan's suggestion is accomplished (in my tree). Sean, do you want to begin
begging now?

Comment 8

[Sean Cotter]

Just checked in content updates for Mozilla and TOC targets. Will request sr=.

Comment 9

[Alec Flett]

Comment on attachment 83124 [details] [diff] [review]
patch for adding Help button to Page Info dlog

sr=alecf

Comment 10

[Ian Oeschger (gone)]

Marking FIXED. Checked in on trunk. Adding adt1.0.0 for consideration on the branch

Comment 11

[Jaime Rodriguez, Jr.]

Should've gotten a r= before it got on the trunk. Removing adt1.0.0, until the
patch has a r=.

Comment 12

[rudman]

Bhuvan provided an "r" in comment #6.

Comment 13

[Daniel Brooks [:db48x]]

Comment on attachment 83124 [details] [diff] [review]
patch for adding Help button to Page Info dlog

r=db48x

other than those blank lines in at the end of pageInfo.dtd, it looks just
dandy.

Comment 14

[Daniel Brooks [:db48x]]

add keyword again.

oh, and I really don't care about moving the window size to the dtd. more bother
than it's worth really.

Comment 15

[Jaime Rodriguez, Jr.]

Re-Instating adt1.0.0.

Comment 16

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Driver's approval.  After, checking in, please add the fixed1.0 keyword.

Comment 17

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 18

[Judson Valeski]

please land this on the 1.0.1 branch. once there remove the "mozilla1.0.1+"
keyword, and add the "fixed1.0.1"

Comment 19

[Ian Oeschger (gone)]

FIXED on branch. Adding fixed1.0.1 keyword

Comment 20

[lchiang]

verified on branch 1.0 8-23 build, Win2k.

[e-mail] - can you verify on Mac and/or Linux?

Comment 21

[R.J. Keller]

v