1404871 - Popup cut-off if put into overflow menu

Status: RESOLVED DUPLICATE of bug 1448276

(WebExtensions :: General, defect, P3)

Description

[Jan Alexander Steffens [:heftig]]

When the popup for my extension is put into the overflow menu, the bottom of the page is cut off, replaced by white space.

The code for the popup is dead-simple, no dynamic layout and barely any CSS:
https://github.com/heftig/sort-bookmarks/tree/master/popup

The <browser> for the popup is the correct size (height: 315px) and removing the "max-height: 315px" from the enclosing <panelview> restores the bottom of the popup. Since the panelview also encloses the panel-header, it seems the header was forgotten when calculating the max-height.

AMO: https://addons.mozilla.org/en-US/firefox/addon/sort-bookmarks-webext/

The extension can also be loaded immediately from git, no build step necessary.

Comment 1

[Jan Alexander Steffens [:heftig]]

Attachment: Popup from toolbar (works)

Comment 2

[Jan Alexander Steffens [:heftig]]

Attachment: Popup from overflow menu (broken)

Comment 4

[Jan Alexander Steffens [:heftig]]

That doesn't seem to be right; Bug 1373490 is about the popup size being not completely controllable, but this bug is about the bottom being cut off even in a popup that should fit.

Comment 5

[Jan Alexander Steffens [:heftig]]

To be clear, since 1373490 mentions that the width limitation is by design, I believe that a fix for that bug would necessarily be different (even if it's just the addition of scrollbars) to a fix for the height calculation in this bug.

The problem here is not a limitation of the size of the overflow menu. In fact, I can still increase the height of the popup, but a section at the bottom (empty or not) is always cut off.

Comment 6

[Jan Alexander Steffens [:heftig]]

Attachment: Minimal demo extension

In the attached extension's popup, the "foo" paragraph is visible in the overflow menu, but the "bar" paragraph is cut off.

Comment 7

[Tomislav Jovanovic :zombie]

Seems this is not an extension-specific problem, and even cuts off even the simplest popup html.

Comment 8

[Firefox Bug Husbandry Bot]

Bulk move of bugs per https://bugzilla.mozilla.org/show_bug.cgi?id=1483958