1405431 - Intermittent dom/webauthn/tests/test_webauthn_loopback.html | Signing signature invalid: Invalid signature length: 69

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=134608446&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/MpO-wyM-S-OWiVj_ZlKyQg/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1405431 - Be more precise in WebAuthn signature verification assertion

There's an intermittent which might be spurious because ASN.1 signatures might
sometimes be less than 70 bytes, but the actual floor is probably 68 (32 + 32
+ 4).

It's a sanity check, so I've adjusted it down and also am now emitting the
offending key bytes if this triggers again.

Review commit: https://reviewboard.mozilla.org/r/186462/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186462/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8915236 [details]
Bug 1405431 - Be more precise in WebAuthn signature verification assertion

https://reviewboard.mozilla.org/r/186462/#review191548

Ok - sounds like a plan.

::: dom/webauthn/tests/u2futil.js:287
(Diff revision 1)
>    return ret;
>  }
>  
>  function verifySignature(key, data, derSig) {
> -  if (derSig.byteLength < 70) {
> -    console.log("bad sig: " + hexEncode(new Uint8Array(derSig)))
> +  if (derSig.byteLength < 68) {
> +    return Promise.reject("Invalid signature (length=" + derSig.byteLength +

Huh - you'd think console messages would be useful to have when a test fails, but I guess... we... just... don't...?

Comment 3

[J.C. Jones [:jcj] (he/him)]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> Comment on attachment 8915236 [details]
> Huh - you'd think console messages would be useful to have when a test
> fails, but I guess... we... just... don't...?

Yeaahh.

Anyway, I'm pretty sure (~85%) this will just resolve the intermittent, so not going to leave-open this time.

Thanks for the reviews. Marking checkin-needed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e8554fbafad
Be more precise in WebAuthn signature verification assertion r=keeler

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1e8554fbafad

Comment 6

[Intermittent Failures Robot]

4 failures in 824 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1

Platform breakdown:
* windows7-32: 1
* windows10-64-stylo-disabled: 1
* linux64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405431&startday=2017-10-02&endday=2017-10-08&tree=all