Intermittent dom/webauthn/tests/test_webauthn_loopback.html | Signing signature invalid: Invalid signature length: 69

RESOLVED FIXED in Firefox 58

Status

()

defect
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: intermittent-bug-filer, Assigned: jcj)

Tracking

({intermittent-failure})

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [webauthn][webauthn-test])

Attachments

(1 attachment)

Assignee: nobody → jjones
Status: NEW → ASSIGNED
Whiteboard: [webauthn][webauthn-test]
Comment on attachment 8915236 [details]
Bug 1405431 - Be more precise in WebAuthn signature verification assertion

https://reviewboard.mozilla.org/r/186462/#review191548

Ok - sounds like a plan.

::: dom/webauthn/tests/u2futil.js:287
(Diff revision 1)
>    return ret;
>  }
>  
>  function verifySignature(key, data, derSig) {
> -  if (derSig.byteLength < 70) {
> -    console.log("bad sig: " + hexEncode(new Uint8Array(derSig)))
> +  if (derSig.byteLength < 68) {
> +    return Promise.reject("Invalid signature (length=" + derSig.byteLength +

Huh - you'd think console messages would be useful to have when a test fails, but I guess... we... just... don't...?
Attachment #8915236 - Flags: review?(dkeeler) → review+
(In reply to David Keeler [:keeler] (use needinfo?) from comment #2)
> Comment on attachment 8915236 [details]
> Huh - you'd think console messages would be useful to have when a test
> fails, but I guess... we... just... don't...?

Yeaahh.

Anyway, I'm pretty sure (~85%) this will just resolve the intermittent, so not going to leave-open this time.

Thanks for the reviews. Marking checkin-needed.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1e8554fbafad
Be more precise in WebAuthn signature verification assertion r=keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1e8554fbafad
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.