1401803 - [WebAuth] Return ArrayBuffer instead of UInt8Array

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Matt Wobensmith [:mwobensmith][:matt:]]

As surfaced in interop testing, we should return objects of type ArrayBuffer instead of UInt8Array objects.

This will require modification of existing tests as well.

Comment 1

[J.C. Jones [:jcj] (he/him)]

Attachment: Bug 1401803 - WebAuthn types need to return ArrayBuffers

The Web Authentication types, by spec, return ArrayBuffer objects, while we
were returning a concrete Uint8Array. This is a fairly straightforward change
to add functionality to CryptoBuffer and the WebIDL types, however it's a
substantial change to the tests.

Frankly, the tests just could use another pass of clean-up now, since this is
a lot of relative ugliness added in. I refactored tab_webauthn_success.html
pretty heavily -- since it was also fairly ugly to start -- but I decided to go
with a lighter touch on the other tests.

Review commit: https://reviewboard.mozilla.org/r/184768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184768/

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8913433 [details]
Bug 1401803 - WebAuthn types need to return ArrayBuffers

https://reviewboard.mozilla.org/r/184768/#review190162

LGTM - just the one comment.

::: dom/webauthn/tests/u2futil.js:288
(Diff revision 1)
>  }
>  
>  function verifySignature(key, data, derSig) {
> -  let sigAsn1 = org.pkijs.fromBER(derSig.buffer);
> +  if (derSig.byteLength < 70) {
> +    console.log("bad sig: " + hexEncode(new Uint8Array(derSig)))
> +    throw "Invalid signature length: " + derSig.byteLength;

Should this be `return Promise.reject("...");`?

Comment 3

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8913433 [details]
Bug 1401803 - WebAuthn types need to return ArrayBuffers

https://reviewboard.mozilla.org/r/184768/#review190162

Thanks for the review!

> Should this be `return Promise.reject("...");`?

Wouldn't hurt!

Comment 4

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 8913433 [details]
Bug 1401803 - WebAuthn types need to return ArrayBuffers

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184768/diff/1-2/

Comment 5

[J.C. Jones [:jcj] (he/him)]

Try run is OK. Marking checkin-needed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4e07901ada4
WebAuthn types need to return ArrayBuffers r=keeler

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4e07901ada4