Closed
Bug 1405465
Opened 8 years ago
Closed 7 years ago
Handle WR paint codepath with no frame
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | unaffected |
| firefox63 | --- | fixed |
People
(Reporter: kats, Assigned: sotaro)
References
Details
(Whiteboard: [wr-reserve] [gfx-noted])
Attachments
(1 file, 6 obsolete files)
|
8.26 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
It seems that in some cases frame is nullptr at [1] and we go down this fallback path where we try to create a color layer and finish a (layers) transaction. However we don't really support doing that sort of thing in (layers-free) webrender, so we should implement a WR-specific codepath there.
[1] http://searchfox.org/mozilla-central/rev/a4702203522745baff21e519035b6c946b7d710d/layout/base/PresShell.cpp#6419
|
||
Updated•8 years ago
|
|
||
Updated•8 years ago
|
Priority: P3 → P2
Whiteboard: [gfx-noted][wr-mvp][triage] → [wr-mvp] [gfx-noted]
|
|
||
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [wr-mvp] [gfx-noted] → [wr-reserve] [gfx-noted]
|
|
||
Updated•8 years ago
|
Priority: P3 → P1
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 6•7 years ago
|
||
Attachment #8988379 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•7 years ago
|
||
|
|
Assignee | |
Comment 9•7 years ago
|
||
attachment 8988382 [details] [diff] [review] was create by referring an implementation with ColorLayer.
https://dxr.mozilla.org/mozilla-central/source/layout/base/PresShell.cpp#6324
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8988382 -
Flags: review?(bugmail)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8988382 -
Flags: review?(bugmail)
|
|
Assignee | |
Comment 10•7 years ago
|
||
Attachment #8988382 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8988416 -
Flags: review?(bugmail)
|
Reporter | |
Comment 11•7 years ago
|
||
Comment on attachment 8988416 [details] [diff] [review]
patch - Handle WR paint codepath with no frame
Review of attachment 8988416 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, thanks!
Attachment #8988416 -
Flags: review?(bugmail) → review+
|
||
Comment 12•7 years ago
|
||
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8a19147238
Handle WR paint codepath with no frame r=kats
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Comment 14•7 years ago
|
||
Perf win on Linux 64 QR!
== Change summary for alert #14197 (as of Thu, 05 Jul 2018 07:38:32 GMT) ==
Improvements:
3% sessionrestore_many_windows linux64-qr opt e10s stylo 1,507.58 -> 1,464.92
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=14197
You need to log in
before you can comment on or make changes to this bug.
Description
•