1405550 - stylo: Adjust assertion count of crash tests for stylo on Android

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

Actually, when building stylo on android, assertion count on stylo on android is different.

REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/base/crashtests/453894-1.xhtml | assertion count 2 is more than expected 1 assertions
REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/forms/crashtests/590302-1.xhtml | assertion count 8 is more than expected 4 to 7 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1015844.html | assertion count 274 is less than expected 543 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1272983-1.html | assertion count 1 is less than expected 2 assertions
REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1272983-2.html | assertion count 1 is less than expected 2 assertions

This is assertion count, so we should adjust this value for stylo on android

Comment 1

[Hiroyuki Ikezoe (:hiro)]

What are the assertions actually?

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> What are the assertions actually?

layout/base/crashtests/453894-1.xhtml

I/Gecko   (  853): [853, Main Thread] ###!!! ASSERTION: didn't subtract all that we added: '(space == 0 || space == nscoord_MAX) && ((l2t == FLEX_PCT_LARGE) ? (-0.001f < basis.f && basis.f < 0.001f) : (basis.c == 0 || basis.c == nscoord_MAX))', file /home/mkato/Development/hg.mozilla.org/mobile/layout/tables/BasicTableLayoutStrategy.cpp, line 1058
I/Gecko   (  853): [853, Main Thread] ###!!! ASSERTION: didn't subtract all that we added: '(space == 0 || space == nscoord_MAX) && ((l2t == FLEX_PCT_LARGE) ? (-0.001f < basis.f && basis.f < 0.001f) : (basis.c == 0 || basis.c == nscoord_MAX))', file /home/mkato/Development/hg.mozilla.org/mobile/layout/tables/BasicTableLayoutStrategy.cpp, line 1058


layout/forms/crashtests/590302-1.xhtml

I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Cannot bind twice, need to unbind first: '!mBoundFrame', file /home/mkato/Development/hg.mozilla.org/mobile/dom/html/nsTextEditorState.cpp, line 1321
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Cannot bind twice, need to unbind first: '!mBoundFrame', file /home/mkato/Development/hg.mozilla.org/mobile/dom/html/nsTextEditorState.cpp, line 1321
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233
I/Gecko   ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233

layout/generic/crashtests/1015844.html 

a lot of the following assertions.
I/Gecko   ( 2085): [2085, Main Thread] ###!!! ASSERTION: overflow containers must be zero-block-size: 'finalSize.BSize(wm) == 0', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsBlockFrame.cpp, line 1710

Comment 3

[Makoto Kato [:m_kato]]

layout/generic/crashtests/1272983-1.html 

I/Gecko   ( 1350): [1350, Main Thread] ###!!! ASSERTION: Returning bogus 0-sized margin, because this margin depends on layout & isn't cached!: 'Error', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsFrame.cpp, line 1154

layout/generic/crashtests/1272983-2.html 

I/Gecko   ( 1595): [1595, Main Thread] ###!!! ASSERTION: Returning bogus 0-sized padding, because this padding depends on layout & isn't cached!: 'Error', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsFrame.cpp, line 1230

Comment 4

[Emilio Cobos Álvarez [:emilio]]

As long as the assertions are the same as with stylo disabled, just different in count, it's ok to adjust the count imo.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1405550 - Adjust assertion count of crash tests for stylo on Android.

Review commit: https://reviewboard.mozilla.org/r/191504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191504/

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8920505 [details]
Bug 1405550 - Adjust assertion count of crash tests for stylo on Android.

https://reviewboard.mozilla.org/r/191504/#review196706

r=me, thanks a lot for your work on Stylo on Android!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4917ee6fce4
Adjust assertion count of crash tests for stylo on Android. r=emilio

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4917ee6fce4