Closed
Bug 1405550
Opened 7 years ago
Closed 7 years ago
stylo: Adjust assertion count of crash tests for stylo on Android
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
Actually, when building stylo on android, assertion count on stylo on android is different. REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/base/crashtests/453894-1.xhtml | assertion count 2 is more than expected 1 assertions REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/forms/crashtests/590302-1.xhtml | assertion count 8 is more than expected 4 to 7 assertions REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1015844.html | assertion count 274 is less than expected 543 assertions REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1272983-1.html | assertion count 1 is less than expected 2 assertions REFTEST TEST-UNEXPECTED-PASS | http://10.0.2.2:8854/tests/layout/generic/crashtests/1272983-2.html | assertion count 1 is less than expected 2 assertions This is assertion count, so we should adjust this value for stylo on android
Assignee | ||
Updated•7 years ago
|
Blocks: stylo-android
Comment 1•7 years ago
|
||
What are the assertions actually?
Component: Layout → CSS Parsing and Computation
Summary: Adjust assertion count of crash tests for stylo on Android → stylo: Adjust assertion count of crash tests for stylo on Android
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → m_kato
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1) > What are the assertions actually? layout/base/crashtests/453894-1.xhtml I/Gecko ( 853): [853, Main Thread] ###!!! ASSERTION: didn't subtract all that we added: '(space == 0 || space == nscoord_MAX) && ((l2t == FLEX_PCT_LARGE) ? (-0.001f < basis.f && basis.f < 0.001f) : (basis.c == 0 || basis.c == nscoord_MAX))', file /home/mkato/Development/hg.mozilla.org/mobile/layout/tables/BasicTableLayoutStrategy.cpp, line 1058 I/Gecko ( 853): [853, Main Thread] ###!!! ASSERTION: didn't subtract all that we added: '(space == 0 || space == nscoord_MAX) && ((l2t == FLEX_PCT_LARGE) ? (-0.001f < basis.f && basis.f < 0.001f) : (basis.c == 0 || basis.c == nscoord_MAX))', file /home/mkato/Development/hg.mozilla.org/mobile/layout/tables/BasicTableLayoutStrategy.cpp, line 1058 layout/forms/crashtests/590302-1.xhtml I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Cannot bind twice, need to unbind first: '!mBoundFrame', file /home/mkato/Development/hg.mozilla.org/mobile/dom/html/nsTextEditorState.cpp, line 1321 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Cannot bind twice, need to unbind first: '!mBoundFrame', file /home/mkato/Development/hg.mozilla.org/mobile/dom/html/nsTextEditorState.cpp, line 1321 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 I/Gecko ( 1102): [1102, Main Thread] ###!!! ASSERTION: Child must be scrollable: 'scrollableFrame', file /home/mkato/Development/hg.mozilla.org/mobile/layout/forms/nsTextControlFrame.cpp, line 233 layout/generic/crashtests/1015844.html a lot of the following assertions. I/Gecko ( 2085): [2085, Main Thread] ###!!! ASSERTION: overflow containers must be zero-block-size: 'finalSize.BSize(wm) == 0', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsBlockFrame.cpp, line 1710
Assignee | ||
Comment 3•7 years ago
|
||
layout/generic/crashtests/1272983-1.html I/Gecko ( 1350): [1350, Main Thread] ###!!! ASSERTION: Returning bogus 0-sized margin, because this margin depends on layout & isn't cached!: 'Error', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsFrame.cpp, line 1154 layout/generic/crashtests/1272983-2.html I/Gecko ( 1595): [1595, Main Thread] ###!!! ASSERTION: Returning bogus 0-sized padding, because this padding depends on layout & isn't cached!: 'Error', file /home/mkato/Development/hg.mozilla.org/mobile/layout/generic/nsFrame.cpp, line 1230
Updated•7 years ago
|
status-firefox57:
--- → disabled
Priority: -- → P3
Comment 4•7 years ago
|
||
As long as the assertions are the same as with stylo disabled, just different in count, it's ok to adjust the count imo.
Updated•7 years ago
|
Status: NEW → ASSIGNED
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8920505 [details] Bug 1405550 - Adjust assertion count of crash tests for stylo on Android. https://reviewboard.mozilla.org/r/191504/#review196706 r=me, thanks a lot for your work on Stylo on Android!
Attachment #8920505 -
Flags: review?(emilio) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/e4917ee6fce4 Adjust assertion count of crash tests for stylo on Android. r=emilio
![]() |
||
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4917ee6fce4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•