1366049 - (stylo-android) enable Stylo for Android

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Nathan Froyd [:froydnj]]

We're planning on not enabling Stylo on Android for the initial release, but it'd be good to do it sooner rather than later.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b83d8a6a1323daf7d42c75148246b9f4b4bbd476 for android-api-16.

When using gcc 4.9, APK is 1.6MB+
When using clang 5.0 (the latest NDK), APK is 1.4MB+

Comment 2

[Makoto Kato [:m_kato]]

(clang's data is old changeset, not same changeset)

Comment 3

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57

Comment 4

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9008dc8fe81f62ea1f23529c876ddd4be97c04cf

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1366049 - enable Stylo for Android.

All tests are passed with stylo, So let's turn on stylo even if Android.

Review commit: https://reviewboard.mozilla.org/r/201586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201586/

Comment 6

[Jan Beich]

(In reply to Makoto Kato [:m_kato] from comment #5)
> All tests are passed with stylo, So let's turn on stylo even if Android.

Despite Try build from comment 4 using "enable_stylo = None" ?

Comment 7

[Makoto Kato [:m_kato]]

(In reply to Jan Beich from comment #6)
> (In reply to Makoto Kato [:m_kato] from comment #5)
> > All tests are passed with stylo, So let's turn on stylo even if Android.
> 
> Despite Try build from comment 4 using "enable_stylo = None" ?

Ah, I send it again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304

Comment 8

[Makoto Kato [:m_kato]]

(Last week, xpcshell was passed again, also, reftests was already passed )

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8930416 [details]
Bug 1366049 - enable Stylo for Android.

https://reviewboard.mozilla.org/r/201586/#review206892

Comment 10

[Bob Clary [:bc] (inactive)]

I don't see that Autophone has been tested yet. I have submitted tests using your try build at:
<https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304&group_state=expanded&filter-searchStr=autophone>

Let's wait for that to complete before landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9353a526c194
enable Stylo for Android. r=snorp

Comment 12

[Noemi Erli[:noemi_erli]]

Backed out changeset 9353a526c194 (bug 1366049) for bustage in /python/mozbuild/mozbuild/test/configure/lint.py r=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/565c65d130adbeb633655fcddc8af6b2aaf818fb

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9353a526c1940a9ce4e0c07b79ba08727b8fa176&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 8930416 [details]
Bug 1366049 - enable Stylo for Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201586/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db56323cd08f
enable Stylo for Android. r=snorp

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/db56323cd08f

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Adding a release note for 59 dev edition/beta; New, Added support for Stylo for Android

Comment 17

[Chris Mills [:cmills]]

I have added a note to the Fx59 rel notes to cover this; let me know if you think this reads OK, and if there's anything more you'd like me to say:

https://developer.mozilla.org/en-US/Firefox/Releases/59#Stylo_comes_to_Firefox_for_Android_in_59

Comment 18

[Chris Peterson [:cpeterson]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> I have added a note to the Fx59 rel notes to cover this; let me know if you
> think this reads OK, and if there's anything more you'd like me to say:
> 
> https://developer.mozilla.org/en-US/Firefox/Releases/
> 59#Stylo_comes_to_Firefox_for_Android_in_59

cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we should remove Stylo from the Firefox 59's Android release notes.

Comment 19

[Chris Mills [:cmills]]

(In reply to Chris Peterson [:cpeterson] from comment #18)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> > I have added a note to the Fx59 rel notes to cover this; let me know if you
> > think this reads OK, and if there's anything more you'd like me to say:
> > 
> > https://developer.mozilla.org/en-US/Firefox/Releases/
> > 59#Stylo_comes_to_Firefox_for_Android_in_59
> 
> cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we
> should remove Stylo from the Firefox 59's Android release notes.

Cool, thanks for letting me know - removed.

Comment 20

[Julien Cristau [:jcristau]]

Added in the draft 60.0beta release notes: