Bug 1366049 (stylo-android)

enable Stylo for Android

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P4
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: froydnj, Assigned: m_kato)

Tracking

(Depends on 2 bugs, {dev-doc-complete})

Trunk
mozilla59
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 60+, firefox57 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
We're planning on not enabling Stylo on Android for the initial release, but it'd be good to do it sooner rather than later.
Priority: -- → P4
Alias: stylo-android
Assignee

Updated

2 years ago
Depends on: 1397764
Assignee

Comment 1

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b83d8a6a1323daf7d42c75148246b9f4b4bbd476 for android-api-16.

When using gcc 4.9, APK is 1.6MB+
When using clang 5.0 (the latest NDK), APK is 1.4MB+
Assignee

Comment 2

2 years ago
(clang's data is old changeset, not same changeset)
Assignee

Updated

2 years ago
Depends on: 1399337
Assignee

Updated

2 years ago
Depends on: 1401845
Assignee

Updated

2 years ago
Depends on: 1403074
Depends on: 1403766
Depends on: 1404545
Blocks: 1308785
Assignee

Updated

2 years ago
Depends on: 1405548
Assignee

Updated

2 years ago
Depends on: 1405550
Assignee

Updated

2 years ago
Depends on: 1406290
Depends on: 1404178
Assignee

Updated

2 years ago
Depends on: 1407525
Assignee

Updated

2 years ago
Depends on: 1408847
Assignee

Updated

2 years ago
Depends on: 1410336
Assignee

Updated

2 years ago
Depends on: 1411522
Assignee

Updated

2 years ago
Depends on: 1411802
Assignee

Updated

2 years ago
Depends on: 1412774
status-firefox57=wontfix unless someone thinks this bug should block 57
Assignee

Updated

2 years ago
Depends on: 1413497
Depends on: 1408300
Assignee

Updated

2 years ago
Depends on: 1417356
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
No longer depends on: 1413497
Assignee

Updated

2 years ago
No longer depends on: 1412774

Comment 6

2 years ago
(In reply to Makoto Kato [:m_kato] from comment #5)
> All tests are passed with stylo, So let's turn on stylo even if Android.

Despite Try build from comment 4 using "enable_stylo = None" ?
Assignee

Comment 7

2 years ago
(In reply to Jan Beich from comment #6)
> (In reply to Makoto Kato [:m_kato] from comment #5)
> > All tests are passed with stylo, So let's turn on stylo even if Android.
> 
> Despite Try build from comment 4 using "enable_stylo = None" ?

Ah, I send it again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304
Assignee

Comment 8

2 years ago
(Last week, xpcshell was passed again, also, reftests was already passed )
Assignee

Updated

2 years ago
Assignee: nobody → m_kato

Comment 10

2 years ago
I don't see that Autophone has been tested yet. I have submitted tests using your try build at:
<https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304&group_state=expanded&filter-searchStr=autophone>

Let's wait for that to complete before landing.
Comment hidden (mozreview-request)

Comment 15

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db56323cd08f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee

Updated

2 years ago
Flags: needinfo?(m_kato)
Adding a release note for 59 dev edition/beta; New, Added support for Stylo for Android
I have added a note to the Fx59 rel notes to cover this; let me know if you think this reads OK, and if there's anything more you'd like me to say:

https://developer.mozilla.org/en-US/Firefox/Releases/59#Stylo_comes_to_Firefox_for_Android_in_59
Depends on: 1432354
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> I have added a note to the Fx59 rel notes to cover this; let me know if you
> think this reads OK, and if there's anything more you'd like me to say:
> 
> https://developer.mozilla.org/en-US/Firefox/Releases/
> 59#Stylo_comes_to_Firefox_for_Android_in_59

cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we should remove Stylo from the Firefox 59's Android release notes.
Flags: needinfo?(cmills)
(In reply to Chris Peterson [:cpeterson] from comment #18)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> > I have added a note to the Fx59 rel notes to cover this; let me know if you
> > think this reads OK, and if there's anything more you'd like me to say:
> > 
> > https://developer.mozilla.org/en-US/Firefox/Releases/
> > 59#Stylo_comes_to_Firefox_for_Android_in_59
> 
> cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we
> should remove Stylo from the Firefox 59's Android release notes.

Cool, thanks for letting me know - removed.
Flags: needinfo?(cmills)
Added in the draft 60.0beta release notes:
You need to log in before you can comment on or make changes to this bug.