Closed Bug 1366049 (stylo-android) Opened 3 years ago Closed 3 years ago

enable Stylo for Android

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
relnote-firefox --- 60+
firefox57 --- wontfix
firefox59 --- fixed

People

(Reporter: froydnj, Assigned: m_kato)

References

(Depends on 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We're planning on not enabling Stylo on Android for the initial release, but it'd be good to do it sooner rather than later.
Priority: -- → P4
Alias: stylo-android
Depends on: 1397764
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b83d8a6a1323daf7d42c75148246b9f4b4bbd476 for android-api-16.

When using gcc 4.9, APK is 1.6MB+
When using clang 5.0 (the latest NDK), APK is 1.4MB+
(clang's data is old changeset, not same changeset)
Depends on: 1399337
Depends on: 1401845
Depends on: 1403074
Depends on: 1403766
Depends on: 1404545
Blocks: 1308785
Depends on: 1405548
Depends on: 1405550
Depends on: 1406290
Depends on: 1404178
Depends on: 1407525
Depends on: 1408847
Depends on: 1410336
Depends on: 1411522
Depends on: 1411802
Depends on: 1412774
status-firefox57=wontfix unless someone thinks this bug should block 57
Depends on: 1413497
Depends on: 1408300
Depends on: 1417356
No longer depends on: 1413497
No longer depends on: 1412774
(In reply to Makoto Kato [:m_kato] from comment #5)
> All tests are passed with stylo, So let's turn on stylo even if Android.

Despite Try build from comment 4 using "enable_stylo = None" ?
(In reply to Jan Beich from comment #6)
> (In reply to Makoto Kato [:m_kato] from comment #5)
> > All tests are passed with stylo, So let's turn on stylo even if Android.
> 
> Despite Try build from comment 4 using "enable_stylo = None" ?

Ah, I send it again. https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304
(Last week, xpcshell was passed again, also, reftests was already passed )
Assignee: nobody → m_kato
I don't see that Autophone has been tested yet. I have submitted tests using your try build at:
<https://treeherder.mozilla.org/#/jobs?repo=try&revision=691b5f43a2beb2db880cb0a64aabb3255f9b7304&group_state=expanded&filter-searchStr=autophone>

Let's wait for that to complete before landing.
https://hg.mozilla.org/mozilla-central/rev/db56323cd08f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Flags: needinfo?(m_kato)
Depends on: 1420369
Adding a release note for 59 dev edition/beta; New, Added support for Stylo for Android
I have added a note to the Fx59 rel notes to cover this; let me know if you think this reads OK, and if there's anything more you'd like me to say:

https://developer.mozilla.org/en-US/Firefox/Releases/59#Stylo_comes_to_Firefox_for_Android_in_59
Depends on: 1432354
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> I have added a note to the Fx59 rel notes to cover this; let me know if you
> think this reads OK, and if there's anything more you'd like me to say:
> 
> https://developer.mozilla.org/en-US/Firefox/Releases/
> 59#Stylo_comes_to_Firefox_for_Android_in_59

cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we should remove Stylo from the Firefox 59's Android release notes.
Flags: needinfo?(cmills)
(In reply to Chris Peterson [:cpeterson] from comment #18)
> (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #17)
> > I have added a note to the Fx59 rel notes to cover this; let me know if you
> > think this reads OK, and if there's anything more you'd like me to say:
> > 
> > https://developer.mozilla.org/en-US/Firefox/Releases/
> > 59#Stylo_comes_to_Firefox_for_Android_in_59
> 
> cmills, we are slipping Stylo for Android from Firefox 59 to 60, so we
> should remove Stylo from the Firefox 59's Android release notes.

Cool, thanks for letting me know - removed.
Flags: needinfo?(cmills)
Added in the draft 60.0beta release notes:
You need to log in before you can comment on or make changes to this bug.