1405634 - Add-on popups close when focusing password input field

Status: RESOLVED DUPLICATE of bug 1451466

(Core :: Widget: Gtk, defect, P3)

Description

[Ruben Grimm]

Attachment: Peek 2017-10-04 13-45.gif

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171004000618

Steps to reproduce:

Install an add-on that has a popup with a password field (in my case: pass-browser-firefox and passman).

Click on the add-on icon. (With pass-browser-firefox, the popup only opens for a short time, since the add-on instantly focuses the password field.)

Focus the password field (click into it).


Actual results:

The add-on popup closes.


Expected results:

The add-on popup stays open, focuses the password input, and I can input my password.

Comment 1

[YF (Yang)]

Work for me in Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20171004220309 & Fx57.0b5, with Passman 2.0.3.

Comment 2

[Ruben Grimm]

I'm on Fedora 26.

I tried to use a fresh Firefox profile -> Same problem.
I also tried current Firefox Nightly -> Same problem.

Comment 3

[Ruben Grimm]

When switching to the Wayland Session in Fedora (I was using X11 previously) it works.

Comment 4

[nick]

Also seeing this behavior on Linux/X11 with Bitwarden and Lastpass

Comment 5

[nick]

Just confirmed that switching to Wayland from default X11 seems to solve the issue.

Comment 6

[johnk]

Confirmed not working on Ubuntu 18.04 default. Tested with BitWarden.

Comment 7

[Diep Pham]

This bug also affects me on a fresh installed Ubuntu 18.04 machine.

Comment 8

[Yugandhar Veeramachaneni]

Can confirm. Fresh new install of Ubuntu 18.04 and experiencing this with bitwarden.

Comment 9

[Diep Pham]

Anyone knows of a workaround for this problem? It made Firefox unusable for me.

Comment 10

[Yugandhar Veeramachaneni]

@Diep Switching to Wayland solves this issue for me.

Comment 11

[Diep Pham]

> Switching to Wayland solves this issue for me.

Unfortunately the Wayland session doens't work for me, I guess because incompatible with NVDIA video card.

Comment 12

[nick]

If you open the Bookmarks sidebar, you can click on the header and select BitWarden and use it in sidebar mode, and it does not have issues.

Comment 13

[johnk]

(In reply to Diep Pham from comment #11)
> > Switching to Wayland solves this issue for me.
> 
> Unfortunately the Wayland session doens't work for me, I guess because
> incompatible with NVDIA video card.

check out https://bugzilla.mozilla.org/show_bug.cgi?id=1451418#c4 you can toggle it on/off until this gets fixed.

Comment 14

[Diep Pham]

> If you open the Bookmarks sidebar, you can click on the header and select BitWarden and use it in sidebar mode, and it does not have issues.

Bitwarden is easy to workaround, I just stop using the extension altogether and rely on copy/paste from the desktop client. The real annoying one is the Metamask addon.

> check out https://bugzilla.mozilla.org/show_bug.cgi?id=1451418#c4 you can toggle it on/off until this gets fixed.

Thank for the tip, but after ui.popup.disable_autohide = true I couldn't figure out how to close those popups except going to about:config and toggle autohide again.

Comment 15

[Diep Pham]

FYI, the bug might be in Ibus package, not firefox https://github.com/ibus/ibus/issues/2002#issuecomment-386537208.

Comment 16

[Diep Pham]

Attachment: ibus-gtk3_1.5.17-3ubuntu4_amd64.deb

I rebuild the ibus-gtk3 package myself with ibus-xx-f19-password patch included and it appear to fixed the problem! I attached the .deb here if anyone wants to try.

Comment 17

[Marcos H. Alano]

I installed this package and worked as expected.

Comment 18

[Yugandhar Veeramachaneni]

Do I need to reboot the machine or restart firefox after installing this package?

Comment 19

[aresaguilarsotos]

I installed Diep Pham's modified version of the Ibus package, restarted Firefox, and Bitwarden popup worked perfectly.

Comment 20

[christosg8]

(In reply to Diep Pham from comment #16)
> Created attachment 8974077 [details]
> ibus-gtk3_1.5.17-3ubuntu4_amd64.deb
> 
> I rebuild the ibus-gtk3 package myself with ibus-xx-f19-password patch
> included and it appear to fixed the problem! I attached the .deb here if
> anyone wants to try.

Yes!!! At last! Thank you so much... This bugs me from the beginning of Firefox Quantum, and first time I saw it using LastPass... Thinking it was their fault, I switched to BitWarden... Staying to BitWarden for now... Thank you so much for providing a patch!

Comment 21

[Ivan Júnior]

(In reply to Diep Pham from comment #14)
> 
> Bitwarden is easy to workaround, I just stop using the extension altogether
> and rely on copy/paste from the desktop client.

I saw you already solved your issue with the deb package. Anyway, instead of using BitWarden Desktop client, you can just use it in sidebar (Shift+Alt+U)... After logged in, it works flawless again.

Comment 22

[Diep Pham]

So as it is confirmed a bug in Gnome Shell: https://gitlab.gnome.org/GNOME/gnome-shell/issues/391, should we just close this issue?

Comment 23

[newsletter]

I can confirm the bug

Comment 24

[Daniel Holbert [:dholbert]]

(In reply to Diep Pham from comment #22)

So as it is confirmed a bug in Gnome Shell:
https://gitlab.gnome.org/GNOME/gnome-shell/issues/391, should we just close
this issue?

Sure -- I'll close this as a duplicate of the main bug that was tracking this issue. (bug 1451466)

Also, good news: a fix has just been released in Ubuntu Bionic (18.04) - so if you install updates & and maybe reboot, this should be fixed for you.

See recent comments on https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1765304 for more (https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1765304/comments/64 in particular)

Comment 25

[alexisgandroid]

I still have that problem.

CentOS Linux release 7.7.1908 (Core), default version with gnome
Firefox 75.0
Bitwarden firefox extension 1.43.4

The popup gets closed with the password field focused.
Using the bitwarden sidebar, I still can write characters but it's blinking like clubbing.

The cause:
With a single input language (en), no problem. With two languages (English + Japanese (Kana Kanji)), it happens.

Conclusion: There is an unfixed issue when there are more than one input source keyboard configured in gnome.

That doesn't happen with Chrome.

Comment 26

[Daniel Holbert [:dholbert]]

(In reply to alexisgandroid from comment #25)

Using the bitwarden sidebar, I still can write characters but it's blinking like clubbing.
[...]
With a single input language (en), no problem. With two languages (English + Japanese (Kana Kanji)), it happens.

That's probably a different bug; the symptoms/causes sound somewhat different, and this bug here turned out to be a bug in external software (which was fixed).

Would you mind filing a new bug for your issue, in this same component? (you can use the "New/Clone" menu at the top right of this bug, and choose "new bug... in this component")

(It sounds like it might be another bad interaction with ibus, like this bug here was. To test that theory, it'd be useful if you could run Firefox from the terminal with environmental variable GTK_IM_MODULE=gtk-im-context-simple set. In other words: quit Firefox, then open a terminal and type...
GTK_IM_MODULE=gtk-im-context-simple firefox
...and see if you can still reproduce.)

Comment 27

[Daniel Holbert [:dholbert]]

Also: to help determine if you might in fact be hitting this same underlying bug, you should check your gnome-shell package version. According to https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1765304/comments/39 , the fix for this issue probably was shipped as part of gnome-shell package version 3.31.2 -- so if your gnome-shell version is older than that, then it's conceivable that you simply haven't received the fix yet.

Note that Ubuntu cherry-picked the patch onto their own dot-releases of older gnome-shell package versions, per e.g. https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1765304/comments/62 , but I have no idea if RedHat/CentOS did that as well.

Comment 28

[alexisgandroid]

Daniel, thank you very much for your reactivity.
I created a new bug but feel free to close it if you think that is solved in that gnome-shell version.
Unfortunately, Centos 7.7.1908 supports only the gnome-shell version 3.28.3 as the last(?) version.