1451418 - When I focus password field in BitWarden Add-on's toolbar-button menu, the menu disappears (with Ubuntu 18.04)

Status: RESOLVED DUPLICATE of bug 1451466

(Core :: Widget: Gtk, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Install Ubuntu 18.04 (liveCD environment probably works -- http://cdimage.ubuntu.com/daily-live/current/ )

  (...or maybe just be running latest Gnome -- my gnome-shell package is version "3.28.0-0ubuntu2")

 2. Start Firefox. (fresh profile if you like)

 3. Install BitWarden from https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager/

 4. Click the BitWarden toolbar icon to spawn a menu-pane.

 5. Click "Log in" at the bottom of that pane.

 6. Click the "Master Password" field.

ACTUAL RESULTS:
 The menu pane disappears as soon as the Master Password field receives focus.

EXPECTED RESULTS:
 I should be able to type in a password; pane shouldn't disappear.


This is new in Ubuntu 18.04 - I got "expected results" on Ubuntu 17.10, but "actual results" on 18.04. (And I've confirmed on several different machines.)

Also, Chrome's BitWarden extension gives "expected results" even on Ubuntu 18.04, so this is a Firefox-specific issue (from the user's perspective), unfortunately.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] (away 4/24 - 5/11) from comment #0)
> This is new in Ubuntu 18.04 - I got "expected results" on Ubuntu 17.10, but
> "actual results" on 18.04. (And I've confirmed on several different
> machines.)

I was testing same Nightly Firefox versions between different machines, too, BTW.

Really, I'm guessing this is a regression in Gnome -- but we probably need to find it & report it, or else Firefox BitWarden users on Linux will suffer.

(Note: For now, my workaround is to log in using the sidebar panel (from e.g. hitting Ctrl+B and then picking BitWarden from the dropdown), rather than the toolbar-icon menu panel.  However -- this is annoying to do, since it requires a few extra steps and BitWarden needs you to enter the master password every time you start Firefox.)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Comment 3

[Daniel Holbert [:dholbert]]

In a debug build, I see this output in my terminal after clicking the password input field:

[Parent 31168, Main Thread] WARNING: ENSURE_TRUE(weakFrame.IsAlive()) failed: file layout/xul/nsXULPopupManager.cpp, line 1186

JavaScript error: chrome://browser/content/parent/ext-menus.js, line 0: Error: Could not find any MenuItem with id: autofill

Comment 4

[Daniel Holbert [:dholbert]]

Basically, when the <input type="password"> receives focus here, it seems like we're mistakenly thinking that the panel has *lost* focus, and so we autohide it.

Probably a bug in widget focus management, or something.

(Also, one terrible workaround [handy for experimenting] is to set ui.popup.disable_autohide = true. That makes this dialog never autohide, i.e. remain open indefinitely, until you unset the pref.)

Comment 5

[Daniel Holbert [:dholbert]]

It actually looks like we lower/blur the whole window (mostly-imperceptibly) *in general* when changing focus into/out-of an input type="password" field!

This can be detected via some extra logging that happens (if you run with MOZ_LOG="Focus:4"), plus there's a bit of a hang because we restyle the whole window (and then maybe restyle it again) for the window-lowering.

Comment 6

[Daniel Holbert [:dholbert]]

After a bit more investigation, I spun off bug 1451466 with a testcase that doesn't use an extension or a menu-popups. (though I suspect it's all the same root problem.)

Comment 7

[johnk]

Confirmed not working on Ubuntu 18.04 default for me as well. That workaround is clutch Daniel!

Comment 8

[nick]

At least with Bitwarden, you can use it in the sidebar of Firefox instead of as a popup, and there are no issues.

Comment 9

[Sergio V]

The only solution I found is to login in the sidebar and then let interact with the plugin. If something doesn't work, the sidebar opens again and it works again.

Comment 10

[Ernst Sjostrand]

It's not that Bitwarden is trying to autofill it's own password field or something like that... ?

Comment 11

[Ernst Sjostrand]

I think this has been fixed in the latest Bitwarden addon update!
WFM.

Comment 12

[Daniel Holbert [:dholbert]]

Per recent comments on bug 1451466 (and on https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1765304 ), this has been fixed upstream in Ubuntu, actually.

I'm just going to resolve this as a dupe of bug 1451466 (though really they're all dupes of that launchpad bug, basically).