Closed Bug 1405637 Opened 2 years ago Closed 2 years ago

Migrate browser_webconsole_notifications.js to the new frontend

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: nchevobbe, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

(Whiteboard: [newconsole-mvp])

Attachments

(1 file)

No description provided.
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [newconsole-mvp]
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Most of the work already done in Bug 1304003, unless we want to support the message-created event (web-console-message-created).

For the record, none of the web-console-* observables are currently used outside of tests. They also are not documented anywhere. We could potentially look at cleaning them up.
Comment on attachment 8943178 [details]
Bug 1405637 - Remove duplicated test browser_webconsole_notifications;

https://reviewboard.mozilla.org/r/213520/#review219306

Seems good to me. Thanks for spotting this Julian
Attachment #8943178 - Flags: review?(nchevobbe) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/680f59bf29d1
Remove duplicated test browser_webconsole_notifications;r=nchevobbe
Priority: P2 → P1
https://hg.mozilla.org/mozilla-central/rev/680f59bf29d1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.