1405927 - Remove Actual Text-Layers

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Aria Beingessner [:Gankra]]

Initially text-layers were useful for webrender to do text, but since we've moved to layers-free, they're now just holding back the webrender impl. In particular TextDrawTarget needs to store glyphs in a "pure" gecko format so that they can be sent to the text-layers code, which in turn forces us to create a second array of glyphs in the wr format.

If we remove text-layers, we can just store glyphs directly in the wr format, eliminating a fairly expensive allocation and copy per text-run.

At this point it's fairly clear to me that text-layers are missing a ton of features, and would be a lot of work to get production ready. I'd rather just take them out now so we can focus our efforts.

Comment 1

[Aria Beingessner [:Gankra]]

Hey mattwoodrow, for my purposes it's sufficient to rip out GetLayerState and BuildLayer from nsDisplayText. However this leaves the actual TextLayer/BasicTextLayer types floating around in the codebase. I'm not sure if anything other than nsDisplayText actually uses such a layer, or if you want to preserve all the glue for TextLayer a little longer. Thoughts?

Comment 2

[Aria Beingessner [:Gankra]]

Attachment: Bug 1405927 - Remove TextLayer support from nsDisplayText.

Review commit: https://reviewboard.mozilla.org/r/186784/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186784/

Comment 3

[Aria Beingessner [:Gankra]]

Attachment: Bug 1405927 - Change PushGlyphs to take webrender formats.

Also cleans up a bunch of TextDrawTarget code as fallout.

This is a significant perf win for textFrames.

Review commit: https://reviewboard.mozilla.org/r/186786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186786/

Comment 4

[Aria Beingessner [:Gankra]]

I've pushed up the current impl without properly removing TextLayer, lmk what y'all want.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8915592 [details]
Bug 1405927 - Change PushGlyphs to take webrender formats.

https://reviewboard.mozilla.org/r/186786/#review191900

Comment 6

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8915591 [details]
Bug 1405927 - Remove TextLayer support from nsDisplayText.

https://reviewboard.mozilla.org/r/186784/#review191990

Comment 7

[Aria Beingessner [:Gankra]]

Comment on attachment 8915591 [details]
Bug 1405927 - Remove TextLayer support from nsDisplayText.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186784/diff/1-2/

Comment 8

[Aria Beingessner [:Gankra]]

Comment on attachment 8915592 [details]
Bug 1405927 - Change PushGlyphs to take webrender formats.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/186786/diff/1-2/

Comment 9

[Aria Beingessner [:Gankra]]

rebased

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e41db689a662
Remove TextLayer support from nsDisplayText. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/54cfd7571517
Change PushGlyphs to take webrender formats. r=jrmuizel

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e41db689a662
https://hg.mozilla.org/mozilla-central/rev/54cfd7571517