Remove TextLayer class (and associated code)

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Gankro, Assigned: Gankro)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox56 wontfix, firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Everyone seems to be in agreement this is incomplete dead code that won't be finished.
Depends on: 1405927
Alexis, are you interested in finishing the removal of TextLayer code?
Flags: needinfo?(a.beingessner)
I am, uh, neutral? I am willing to finish the removal, but am currently focused on improving webrender for the all-hands.
Flags: needinfo?(a.beingessner)
Blocks: 1414282
Since
Assignee: nobody → a.beingessner
Priority: P3 → P1
Err whoops.

Since this code is a security hazard (see above issue), I'm prioritizing removing it.
Never modified ipdl stuff before, so not sure if I need to regen anything explicitly. This patch builds and seems to work fine locally, at least?
Comment on attachment 8935540 [details]
Bug 1406231 - remove the TextLayer class, and all remaining traces of it.

https://reviewboard.mozilla.org/r/206418/#review212082
Attachment #8935540 - Flags: review?(matt.woodrow) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/497efe3a096b
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
Keywords: checkin-needed
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f8dab2a495e
Backed out changeset 497efe3a096b for windows build bustages on build\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(48) r=backout on a CLOSED TREE
Ah dang, looks like this shifted the build system's file concatenation around a bit to reveal some missing imports on windows.
Flags: needinfo?(a.beingessner)
Added new imports to ScrollingLayersHelper.h to fix the unified build.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3355e98fc86be74a7d9dc3bba9ef37cf5b110573
Keywords: checkin-needed
(kinda crossing my fingers that this merges cleanly)
Needs a rebased patch. Also, please be sure to reopen the review request so Autoland can push it.
Flags: needinfo?(a.beingessner)
Keywords: checkin-needed
Changes were made to the file I deleted; should be good now. Going off the previous try results, hoping this hasn't bitrotted in a non-trivial way.
Flags: needinfo?(a.beingessner)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3572bba4d1ae
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/f515861a05f4
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/f515861a05f4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.