1406231 - Remove TextLayer class (and associated code)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P1)

Description

[Aria Beingessner [:Gankra]]

Everyone seems to be in agreement this is incomplete dead code that won't be finished.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Alexis, are you interested in finishing the removal of TextLayer code?

Comment 2

[Aria Beingessner [:Gankra]]

I am, uh, neutral? I am willing to finish the removal, but am currently focused on improving webrender for the all-hands.

Comment 3

[Aria Beingessner [:Gankra]]

Since

Comment 4

[Aria Beingessner [:Gankra]]

Err whoops.

Since this code is a security hazard (see above issue), I'm prioritizing removing it.

Comment 5

[Aria Beingessner [:Gankra]]

Attachment: Bug 1406231 - remove the TextLayer class, and all remaining traces of it.

Review commit: https://reviewboard.mozilla.org/r/206418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206418/

Comment 6

[Aria Beingessner [:Gankra]]

Never modified ipdl stuff before, so not sure if I need to regen anything explicitly. This patch builds and seems to work fine locally, at least?

Comment 7

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8935540 [details]
Bug 1406231 - remove the TextLayer class, and all remaining traces of it.

https://reviewboard.mozilla.org/r/206418/#review212082

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/497efe3a096b
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8dab2a495e
Backed out changeset 497efe3a096b for windows build bustages on build\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(48) r=backout on a CLOSED TREE

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for windows build bustages on build\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(48)

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=497efe3a096ba86ed1d373e5ebf19383511117e1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

https://treeherder.mozilla.org/logviewer.html#?job_id=150746311&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/1f8dab2a495e6df770c0d3fe1be8eab84c449a4d

Comment 11

[Aria Beingessner [:Gankra]]

Ah dang, looks like this shifted the build system's file concatenation around a bit to reveal some missing imports on windows.

Comment 12

[Aria Beingessner [:Gankra]]

try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5a6a64df0f9940160e7e4f6054f757c261c06fd

Comment 13

[Aria Beingessner [:Gankra]]

Comment on attachment 8935540 [details]
Bug 1406231 - remove the TextLayer class, and all remaining traces of it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206418/diff/1-2/

Comment 14

[Aria Beingessner [:Gankra]]

Added new imports to ScrollingLayersHelper.h to fix the unified build.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3355e98fc86be74a7d9dc3bba9ef37cf5b110573

Comment 15

[Aria Beingessner [:Gankra]]

(kinda crossing my fingers that this merges cleanly)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Needs a rebased patch. Also, please be sure to reopen the review request so Autoland can push it.

Comment 17

[Aria Beingessner [:Gankra]]

Comment on attachment 8935540 [details]
Bug 1406231 - remove the TextLayer class, and all remaining traces of it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206418/diff/2-3/

Comment 18

[Aria Beingessner [:Gankra]]

Changes were made to the file I deleted; should be good now. Going off the previous try results, hoping this hasn't bitrotted in a non-trivial way.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3572bba4d1ae
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/f515861a05f4
remove the TextLayer class, and all remaining traces of it. r=mattwoodrow

Comment 21

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f515861a05f4

Comment 22

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/3572bba4d1ae