Closed Bug 1406231 Opened 4 years ago Closed 3 years ago
Layer class (and associated code)
59 bytes, text/x-review-board-request
Everyone seems to be in agreement this is incomplete dead code that won't be finished.
4 years ago
Alexis, are you interested in finishing the removal of TextLayer code?
I am, uh, neutral? I am willing to finish the removal, but am currently focused on improving webrender for the all-hands.
Assignee: nobody → a.beingessner
Priority: P3 → P1
Err whoops. Since this code is a security hazard (see above issue), I'm prioritizing removing it.
Never modified ipdl stuff before, so not sure if I need to regen anything explicitly. This patch builds and seems to work fine locally, at least?
Comment on attachment 8935540 [details] Bug 1406231 - remove the TextLayer class, and all remaining traces of it. https://reviewboard.mozilla.org/r/206418/#review212082
Attachment #8935540 - Flags: review?(matt.woodrow) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/497efe3a096b remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1f8dab2a495e Backed out changeset 497efe3a096b for windows build bustages on build\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(48) r=backout on a CLOSED TREE
Backed out for windows build bustages on build\build\src\obj-firefox\dist\include\mozilla/layers/ScrollingLayersHelper.h(48) https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=497efe3a096ba86ed1d373e5ebf19383511117e1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable https://treeherder.mozilla.org/logviewer.html#?job_id=150746311&repo=autoland https://hg.mozilla.org/integration/autoland/rev/1f8dab2a495e6df770c0d3fe1be8eab84c449a4d
Ah dang, looks like this shifted the build system's file concatenation around a bit to reveal some missing imports on windows.
Added new imports to ScrollingLayersHelper.h to fix the unified build. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3355e98fc86be74a7d9dc3bba9ef37cf5b110573
(kinda crossing my fingers that this merges cleanly)
Needs a rebased patch. Also, please be sure to reopen the review request so Autoland can push it.
Changes were made to the file I deleted; should be good now. Going off the previous try results, hoping this hasn't bitrotted in a non-trivial way.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3572bba4d1ae remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/f515861a05f4 remove the TextLayer class, and all remaining traces of it. r=mattwoodrow
You need to log in before you can comment on or make changes to this bug.