1405935 - Restyle nsPref*.cpp

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

Following on from bug 1405908...

Process:

- Patch 1: Run clang-format to fix whitespace.

- Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format.

- Squash the patches together before landing.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1405935 - Restyle nsPref*.cpp (clang-format). .

Review commit: https://reviewboard.mozilla.org/r/186656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186656/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1405935 - Restyle nsPref*.cpp (manual). .

Review commit: https://reviewboard.mozilla.org/r/186658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186658/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8915456 [details]
Bug 1405935 - Restyle nsPref*.cpp (clang-format). .

https://reviewboard.mozilla.org/r/186656/#review191702


C/C++ static analysis found 4 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: modules/libpref/nsPrefBranch.cpp:949
(Diff revision 1)
>  
>  //----------------------------------------------------------------------------
>  // nsPrefLocalizedString
>  //----------------------------------------------------------------------------
>  
> -nsPrefLocalizedString::nsPrefLocalizedString()
> +nsPrefLocalizedString::nsPrefLocalizedString() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

nsPrefLocalizedString::nsPrefLocalizedString() {}
                       ^
                                               = default;

::: modules/libpref/nsPrefBranch.cpp:951
(Diff revision 1)
> -
> -nsPrefLocalizedString::~nsPrefLocalizedString()
> -{
> -}
>  
> +nsPrefLocalizedString::~nsPrefLocalizedString() {}

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]

nsPrefLocalizedString::~nsPrefLocalizedString() {}
                       ^
                                                = default;

::: modules/libpref/nsPrefBranch.cpp:1014
(Diff revision 1)
>  // nsRelativeFilePref
>  //----------------------------------------------------------------------------
>  
>  NS_IMPL_ISUPPORTS(nsRelativeFilePref, nsIRelativeFilePref)
>  
> -nsRelativeFilePref::nsRelativeFilePref()
> +nsRelativeFilePref::nsRelativeFilePref() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

nsRelativeFilePref::nsRelativeFilePref() {}
                    ^
                                         = default;

::: modules/libpref/nsPrefBranch.cpp:1016
(Diff revision 1)
>  
> -nsRelativeFilePref::nsRelativeFilePref()
> +nsRelativeFilePref::nsRelativeFilePref() {}
> -{
> -}
>  
> -nsRelativeFilePref::~nsRelativeFilePref()
> +nsRelativeFilePref::~nsRelativeFilePref() {}

Warning: Use '= default' to define a trivial destructor [clang-tidy: modernize-use-equals-default]

nsRelativeFilePref::~nsRelativeFilePref() {}
                    ^
                                          = default;

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8915457 [details]
Bug 1405935 - Restyle nsPref*.cpp (manual). .

https://reviewboard.mozilla.org/r/186658/#review191986

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8915456 [details]
Bug 1405935 - Restyle nsPref*.cpp (clang-format). .

https://reviewboard.mozilla.org/r/186656/#review191988

Let's also do the changes suggested by the static analysis bot

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2658a2ad200
Restyle nsPref*.cpp. r=felipe.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2658a2ad2001806d2fbc15d9203643f5a7926f3
Bug 1405935 - Restyle nsPref*.cpp. r=felipe.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c2658a2ad200