1405961 - Assertion failure: !aStamp.IsNull() (The timestamp should not be null), at nsDOMNavigationTiming.h:168

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Bob Clary [:bc] (inactive)]

Attachment: Linux Debug Log

1. https://hub.docker.com/

2. Assertion failure: !aStamp.IsNull() (The timestamp should not be null), at /builds/worker/workspace/build/src/obj-firefox/dist/include/nsDOMNavigationTiming.h:168

#01: mozilla::dom::PerformanceEntryBinding::get_duration [s3:gecko-generated-sources:5dab492dc55ca6852bd3f1cce9b96488950a035a65a4d416343f9f0fe36e001521c88226aee0bf3956514e2f5029dba037d7b08e9831c5b8cbf070c139d3dd85/dom/bindings/PerformanceEntryBinding.cpp::110]
#02: mozilla::dom::GenericBindingGetter [dom/bindings/BindingUtils.cpp:2924]
#03: js::CallJSNative [js/src/jscntxtinlines.h:294]
#04: js::InternalCallOrConstruct [js/src/vm/Interpreter.cpp:495]
#05: InternalCall [js/src/vm/Interpreter.cpp:541]
#06: js::Call [js/src/vm/Interpreter.cpp:559]
#07: js::CallGetter [js/src/jsapi.h:74]
#08: GetExistingProperty<(js::AllowGC)1u> [js/src/vm/NativeObject.cpp:2120]
#09: NativeGetPropertyInline<(js::AllowGC)1u> [js/src/vm/NativeObject.cpp:2376]
#10: js::GetProperty [js/src/vm/NativeObject.h:1599]
#11: js::GetProperty [js/src/jsobj.h:812]
#12: Interpret [js/src/vm/Interpreter.cpp:217]
#13: js::RunScript [js/src/vm/Interpreter.cpp:406]
#14: js::InternalCallOrConstruct [js/src/vm/Interpreter.cpp:513]
#15: InternalCall [js/src/vm/Interpreter.cpp:541]
#16: js::jit::DoCallFallback [js/src/jit/BaselineIC.cpp:2534]

Windows, Linux, Nightly/58. Not Beta/57

Comment 1

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

The assertion was added in bug 1403926. Could you please take a look, Valentin?

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1405961 - Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes

Review commit: https://reviewboard.mozilla.org/r/188818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188818/

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

I removed the assertion and added a test to make sure we don't crash.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8917882 [details]
Bug 1405961 - Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes

https://reviewboard.mozilla.org/r/188818/#review194158

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/690513d3ec06
Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes r=baku

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing modified mochitest dom/tests/mochitest/general/test_performance_nav_timing_before_onload.html:

https://hg.mozilla.org/integration/autoland/rev/5594a2f33e1b603be379e84ebd5d5f7ea8d190e9

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=690513d3ec06ab8e3b0bde840cd318ecf5c56ac4&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=137302038&repo=autoland

> TEST-UNEXPECTED-TIMEOUT | dom/tests/mochitest/general/test_performance_nav_timing_before_onload.html | application timed out after 330 seconds with no output

Comment 7

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Comment on attachment 8917882 [details]
Bug 1405961 - Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188818/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/490375161b03
Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes r=baku

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing mochitest dom/tests/mochitest/general/test_resource_timing.html both in normal and in headless mode:

https://hg.mozilla.org/integration/autoland/rev/6fa4473c2f7fb1cf1bbbc1e97def00dbbb66cc80

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=490375161b039f95bd0e988215acdd334f936589&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=137531644&repo=autoland
[task 2017-10-17T12:38:24.412Z] 12:38:24     INFO - TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_resource_timing.html | http://mochi.test:8888/tests/image/test/mochitest/damon.jpg should be a valid entry name 
[task 2017-10-17T12:38:24.412Z] 12:38:24     INFO -     ok@dom/tests/mochitest/general/resource_timing_main_test.html:55:3
[task 2017-10-17T12:38:24.412Z] 12:38:24     INFO -     doTest@dom/tests/mochitest/general/resource_timing_iframe.html:27:3
[task 2017-10-17T12:38:24.412Z] 12:38:24     INFO -     onload@dom/tests/mochitest/general/resource_timing_iframe.html:1:1

Comment 10

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Comment on attachment 8917882 [details]
Bug 1405961 - Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188818/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8124943524c
Remove assertion and ensure PerformanceNavigationTiming can be used before onLoad completes r=baku

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e8124943524c

Comment 13

[Intermittent Failures Robot]

1 failures in 864 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* android-4-3-armv7-api16: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1405961&startday=2017-10-16&endday=2017-10-22&tree=all