Fix flash of untranslated content on Activity Stream search bar

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
18 days ago

People

(Reporter: k88hudson, Assigned: k88hudson)

Tracking

unspecified
Firefox 58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57+ fixed, firefox58 fixed)

Details

User Story

https://github.com/mozilla/activity-stream/compare/firefox-57b6...5420afb0f0dc744430ab1dc4972271be7138419b

Attachments

(1 attachment)

Currently because of quantum perf tests that check for the existence of placeholder text, we render an English string into the search bar on Activity Stream. We would like to remove the English string to improve the experience (i.e. remove the flash of text) for users.
Blocks: 1399961, 1394533
Blocks: 1406120
Depends on: 1404345
User Story: (updated)
Assignee: nobody → khudson
Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

https://reviewboard.mozilla.org/r/186890/#review191950
Attachment #8915689 - Flags: review+
Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

https://reviewboard.mozilla.org/r/186890/#review191952
Attachment #8915689 - Flags: review?(khudson) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fa7c801e2031
Fix flash of untranslated content on Activity Stream search bar. r=k88hudson
https://hg.mozilla.org/mozilla-central/rev/fa7c801e2031
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream quantum target optimization. Blocks tracking-firefox57 blocking bug 1399961.
[User impact if declined]: English text appears before showing localized text making Firefox feel slow. See https://ed.agadak.net/as/57%20uplift.webmhd.webm
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, 20171007100142
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This bug before bug 1406120
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change is replacing a hardcoded "Search the Web" text with empty " "
[String changes made/needed]: Nothing that affects localization
Attachment #8915689 - Flags: approval-mozilla-beta?
Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

Activity stream related fix, Beta57+
Attachment #8915689 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.