1406096 - Fix flash of untranslated content on Activity Stream search bar

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Kate Hudson :k88hudson]

Currently because of quantum perf tests that check for the existence of placeholder text, we render an English string into the search bar on Activity Stream. We would like to remove the English string to improve the experience (i.e. remove the flash of text) for users.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

Review commit: https://reviewboard.mozilla.org/r/186890/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186890/

Comment 2

[Ed Lee :Mardak]

Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

https://reviewboard.mozilla.org/r/186890/#review191950

Comment 3

[Kate Hudson :k88hudson]

Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

https://reviewboard.mozilla.org/r/186890/#review191952

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa7c801e2031
Fix flash of untranslated content on Activity Stream search bar. r=k88hudson

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fa7c801e2031

Comment 6

[Ed Lee :Mardak]

Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream quantum target optimization. Blocks tracking-firefox57 blocking bug 1399961.
[User impact if declined]: English text appears before showing localized text making Firefox feel slow. See https://ed.agadak.net/as/57%20uplift.webmhd.webm
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, 20171007100142
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This bug before bug 1406120
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change is replacing a hardcoded "Search the Web" text with empty " "
[String changes made/needed]: Nothing that affects localization

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915689 [details]
Bug 1406096 - Fix flash of untranslated content on Activity Stream search bar.

Activity stream related fix, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3fecc15c4d29