1406120 - Remove fade delay for about:home

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

A delay on the fade was added in bug 1401682 to avoid a tart regression. But that talos test is using about:newtab and not about:home, so we can apply the delay only there.

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1406120 - Remove fade delay for about:home.

Review commit: https://reviewboard.mozilla.org/r/186902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/186902/

Comment 2

[Kate Hudson :k88hudson]

Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

https://reviewboard.mozilla.org/r/186902/#review191954

Comment 3

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 62a443b0d56b -d eaa0d99df029: rebasing 424371:62a443b0d56b "Bug 1406120 - Remove fade delay for about:home. r=k88hudson" (tip)
merging browser/extensions/activity-stream/install.rdf.in
warning: conflicts while merging browser/extensions/activity-stream/install.rdf.in! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb855465eb9c
Remove fade delay for about:home. r=k88hudson

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/eb855465eb9c

Comment 6

[Ed Lee :Mardak]

Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

Approval Request Comment
[Feature/Bug causing the regression]: Talos tart regression fix from bug 
1401682. Blocks tracking-firefox57 blocking bug 1399961.
[User impact if declined]: Users forced to wait before seeing most of about:home content making Firefox feel slow. See https://ed.agadak.net/as/57%20uplift.webmhd.webm
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, 20171007100142
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This bug after bug 1406096
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change is css removing the transition-delay
[String changes made/needed]: Nope
[Perf win]: From video above, before the content starts showing on average 4.25 frames (30fps) = 141ms after the localized text appears, and after the content starts showing on average 0.2 frames = 6ms. A 23.5x (2350%) improvement.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

Fix targeting perf improvement, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f3c0f8c3973