Remove fade delay for about:home

RESOLVED FIXED in Firefox 57

Status

()

defect
RESOLVED FIXED
2 years ago
20 days ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Trunk
Firefox 58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed, firefox58 fixed)

Details

User Story

https://github.com/mozilla/activity-stream/compare/5420afb0f0dc744430ab1dc4972271be7138419b...firefox-57b7

Attachments

(1 attachment)

A delay on the fade was added in bug 1401682 to avoid a tart regression. But that talos test is using about:newtab and not about:home, so we can apply the delay only there.
Blocks: 1394533
Depends on: 1406096
User Story: (updated)
Assignee: nobody → edilee
Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

https://reviewboard.mozilla.org/r/186902/#review191954
Attachment #8915692 - Flags: review?(khudson) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 62a443b0d56b -d eaa0d99df029: rebasing 424371:62a443b0d56b "Bug 1406120 - Remove fade delay for about:home. r=k88hudson" (tip)
merging browser/extensions/activity-stream/install.rdf.in
warning: conflicts while merging browser/extensions/activity-stream/install.rdf.in! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/eb855465eb9c
Remove fade delay for about:home. r=k88hudson
Blocks: 1405539
https://hg.mozilla.org/mozilla-central/rev/eb855465eb9c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

Approval Request Comment
[Feature/Bug causing the regression]: Talos tart regression fix from bug 
1401682. Blocks tracking-firefox57 blocking bug 1399961.
[User impact if declined]: Users forced to wait before seeing most of about:home content making Firefox feel slow. See https://ed.agadak.net/as/57%20uplift.webmhd.webm
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, 20171007100142
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: This bug after bug 1406096
[Is the change risky?]: No
[Why is the change risky/not risky?]: The change is css removing the transition-delay
[String changes made/needed]: Nope
[Perf win]: From video above, before the content starts showing on average 4.25 frames (30fps) = 141ms after the localized text appears, and after the content starts showing on average 0.2 frames = 6ms. A 23.5x (2350%) improvement.
Attachment #8915692 - Flags: approval-mozilla-beta?
Comment on attachment 8915692 [details]
Bug 1406120 - Remove fade delay for about:home.

Fix targeting perf improvement, Beta57+
Attachment #8915692 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Story: (updated)
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.