Closed Bug 1406205 Opened 2 years ago Closed 2 years ago

Restyle Preferences.cpp

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

Following on from bug 1405935...

Process:

- Patch 1: Run clang-format to fix whitespace.

- Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format.

- Squash the patches together before landing.
Blocks: 1406280
No longer blocks: 1406280
Comment on attachment 8915821 [details]
Bug 1406205 - Restyle Preferences.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187042/#review192090


C/C++ static analysis found 2 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: modules/libpref/Preferences.cpp:279
(Diff revision 1)
>  // Write the preference data to a file.
>  //
>  class PreferencesWriter final
>  {
>  public:
> -  PreferencesWriter()
> +  PreferencesWriter() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

  PreferencesWriter() {}
  ^
                      = default;

::: modules/libpref/Preferences.cpp:733
(Diff revision 1)
>  
>  /*
>   * Constructor/Destructor
>   */
>  
> -Preferences::Preferences()
> +Preferences::Preferences() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

Preferences::Preferences() {}
             ^
                           = default;
Comment on attachment 8915821 [details]
Bug 1406205 - Restyle Preferences.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187042/#review192390
Attachment #8915821 - Flags: review?(felipc) → review+
Comment on attachment 8915822 [details]
Bug 1406205 - Restyle Preferences.cpp (manual). .

https://reviewboard.mozilla.org/r/187058/#review192392
Attachment #8915822 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/638f6196f028
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee: nobody → n.nethercote
You need to log in before you can comment on or make changes to this bug.