1406205 - Restyle Preferences.cpp

Status: RESOLVED FIXED

(Core :: Preferences: Backend, enhancement)

Description

[Nicholas Nethercote [inactive]]

Following on from bug 1405935...

Process:

- Patch 1: Run clang-format to fix whitespace.

- Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format.

- Squash the patches together before landing.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1406205 - Restyle Preferences.cpp (clang-format). .

Review commit: https://reviewboard.mozilla.org/r/187042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187042/

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1406205 - Restyle Preferences.cpp (manual). .

Review commit: https://reviewboard.mozilla.org/r/187058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187058/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8915821 [details]
Bug 1406205 - Restyle Preferences.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187042/#review192090


C/C++ static analysis found 2 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: modules/libpref/Preferences.cpp:279
(Diff revision 1)
>  // Write the preference data to a file.
>  //
>  class PreferencesWriter final
>  {
>  public:
> -  PreferencesWriter()
> +  PreferencesWriter() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

  PreferencesWriter() {}
  ^
                      = default;

::: modules/libpref/Preferences.cpp:733
(Diff revision 1)
>  
>  /*
>   * Constructor/Destructor
>   */
>  
> -Preferences::Preferences()
> +Preferences::Preferences() {}

Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default]

Preferences::Preferences() {}
             ^
                           = default;

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8915821 [details]
Bug 1406205 - Restyle Preferences.cpp (clang-format). .

https://reviewboard.mozilla.org/r/187042/#review192390

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8915822 [details]
Bug 1406205 - Restyle Preferences.cpp (manual). .

https://reviewboard.mozilla.org/r/187058/#review192392

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/638f6196f028
Restyle Preferences.cpp. r=felipe.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/638f6196f028bfd16fb3318a2c1fe10f95d848e8
Bug 1406205 - Restyle Preferences.cpp. r=felipe.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/638f6196f028