Closed
Bug 1406205
Opened 7 years ago
Closed 7 years ago
Restyle Preferences.cpp
Categories
(Core :: Preferences: Backend, enhancement)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
Following on from bug 1405935... Process: - Patch 1: Run clang-format to fix whitespace. - Patch 2: Do manual fix-ups -- braces, rename things, etc. -- and then finish with another clang-format. - Squash the patches together before landing.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8915821 [details] Bug 1406205 - Restyle Preferences.cpp (clang-format). . https://reviewboard.mozilla.org/r/187042/#review192090 C/C++ static analysis found 2 defects in this patch. You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp` If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx ::: modules/libpref/Preferences.cpp:279 (Diff revision 1) > // Write the preference data to a file. > // > class PreferencesWriter final > { > public: > - PreferencesWriter() > + PreferencesWriter() {} Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default] PreferencesWriter() {} ^ = default; ::: modules/libpref/Preferences.cpp:733 (Diff revision 1) > > /* > * Constructor/Destructor > */ > > -Preferences::Preferences() > +Preferences::Preferences() {} Warning: Use '= default' to define a trivial default constructor [clang-tidy: modernize-use-equals-default] Preferences::Preferences() {} ^ = default;
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8915821 [details] Bug 1406205 - Restyle Preferences.cpp (clang-format). . https://reviewboard.mozilla.org/r/187042/#review192390
Attachment #8915821 -
Flags: review?(felipc) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8915822 [details] Bug 1406205 - Restyle Preferences.cpp (manual). . https://reviewboard.mozilla.org/r/187058/#review192392
Attachment #8915822 -
Flags: review?(felipc) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/638f6196f028 Restyle Preferences.cpp. r=felipe.
Assignee | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/638f6196f028bfd16fb3318a2c1fe10f95d848e8 Bug 1406205 - Restyle Preferences.cpp. r=felipe.
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/638f6196f028
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee | ||
Updated•7 years ago
|
Blocks: prefs-cleanup
Updated•6 years ago
|
Assignee: nobody → n.nethercote
You need to log in
before you can comment on or make changes to this bug.
Description
•