1406274 - stylo: Enable stylo for about:reader

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

In bug 1402094, about:reader is specifically blacklisted for servo backend because of its dependency to scoped style. This is expected to be fixed by bug 1204818.

Comment 1

[Chris Peterson [:cpeterson]]

We'll need to fix this bug before we can remove the old style system code.

Comment 2

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

We probably need to prioritize this bug. It would be a blocker for removing the old style system.

Comment 4

[Cameron McCormack (:heycam)]

The patches in bug 1430014 effectively already do this.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Yes, but I think we probably want to do this first before removing the old style system in case there is still some problem with styling about:reader that we don't know yet.

Comment 6

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c107acd6a25d02e288347ba3d15266d36e6e7c0

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Bug 1406274 - Re-enable stylo in about:reader.

Remove the about:reader check for <style scoped>, too, since that is no
longer needed.

Review commit: https://reviewboard.mozilla.org/r/213424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213424/

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8943120 [details]
Bug 1406274 - Re-enable stylo in about:reader.

https://reviewboard.mozilla.org/r/213424/#review219182

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2573f47a1353
Re-enable stylo in about:reader. r=xidorn

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2573f47a1353