Bug 1395112 (stylo-everywhere)

Remove the old style system (and use Stylo everywhere)

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
P2
normal
11 months ago
a month ago

People

(Reporter: hsivonen, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 12 bugs)

Firefox Tracking Flags

(firefox57 wontfix)

Details

Once stylo is enabled on all platforms, we should remove the old style system in the interest of clean-ups and code size.
No longer blocks: 1395114
Depends on: 1374034, 1294570

Updated

11 months ago
status-firefox57: --- → wontfix
Priority: -- → P3
Depends on: 1345025
Depends on: 1406274
Alias: stylo-everywhere
Summary: Remove the old style system → Remove the old style system (and use Stylo everywhere)
Blocks: 1407527
Depends on: 1408300
Depends on: 1408303
Depends on: 1408305
Depends on: 1408308
Depends on: 1408310
Depends on: 1408311
Depends on: 1408312
Depends on: 1408322
Blocks: 1408642
Depends on: 1409278

Updated

9 months ago
Blocks: 1412716
Depends on: 1345702
Blocks: 1394825
Depends on: 1418216
Depends on: 1418217
Depends on: 1418222
Depends on: 1418232
Depends on: 1418245
Depends on: 1418872
Depends on: 1418874
Depends on: 1418899
Depends on: 1418905
Depends on: 1419645
Depends on: 1419709
Depends on: 1390583
No longer depends on: 1418874
Depends on: 1420026
Depends on: 1420039
Depends on: 1420056
Depends on: 1420071
Depends on: 1420113
Depends on: 1420117
Depends on: 1420379
Depends on: 1420383

Updated

8 months ago
Depends on: 1338944

Updated

8 months ago
No longer depends on: 1338944
I have some WIP patches to remove the old style system code, and it results in libxul.so shrinking by 993 KiB.
(On Linux x64.)
Tested again, with --enable-release:

stylo:disabled, old style:enabled  - 87,884,896
stylo:enabled,  old style:enabled  - 93,660,448
stylo:enabled,  old style:disabled - 92,906,592

So only around 736 KB.  And the size regression from enabling stylo is more like 5.5 MiB.

Updated

8 months ago
Blocks: 435426
Blocks: 1399980
Blocks: 1426223
Blocks: 1419641
P2 because we need to remove (or at least disable at compile-time) the old style system code before we ship Stylo-android or Stylo-chrome.
Priority: P3 → P2
Isn’t it the reverse? Don’t we need to stop using the old style system (on Android and in chrome) before we disable/remove it?
(In reply to Simon Sapin (:SimonSapin) from comment #5)
> Isn’t it the reverse? Don’t we need to stop using the old style system (on
> Android and in chrome) before we disable/remove it?

Yeah. I just meant that we want to disable the old style system in the same release we ship on Android and in chrome.
Depends on: 1430014
No longer blocks: 1426223
Depends on: 1434130
Depends on: 1437695

Updated

5 months ago
Depends on: 1443471

Updated

5 months ago
Blocks: 1443725

Updated

5 months ago
Depends on: 1444221

Updated

4 months ago
No longer depends on: 1345702

Updated

4 months ago
Depends on: 1444905
Depends on: 1446954
Depends on: 1447301
Depends on: 1447358
Blocks: 1447561
We didn't wait for mingw builds to be fixed (bug 1390583 and bug 1443471). Instead the mingw builds are being disabled for now (bug 1447414).
No longer depends on: 1390583, 1443471

Updated

4 months ago
Blocks: 1447627

Updated

4 months ago
Blocks: 1421509
Blocks: 1448526
Blocks: 1448529
Blocks: 1448535
Blocks: 1448716
Blocks: 1448726
Blocks: 1448728
Blocks: 1395118
Depends on: 1448757
Blocks: 1448759
Blocks: 1448763
Blocks: 1449039
Depends on: 1449068
Blocks: 1449074
Depends on: 1418874
No longer depends on: 1418874
Depends on: 1410184
Depends on: 1418874
Depends on: 1449087
Blocks: 1449102
Blocks: 1449103
Blocks: 1449089
Blocks: 1449390
Blocks: 1449400
Blocks: 1449517
Blocks: 1449798
Blocks: 1451216
Blocks: 1451178
Blocks: 1451289
Depends on: 1452113

Updated

3 months ago
Blocks: 1452512
Blocks: 1452542
Blocks: 1453180
No longer blocks: 1448759
Blocks: 1456715
No longer depends on: 1410184
You need to log in before you can comment on or make changes to this bug.