Closed
Bug 1406276
Opened 7 years ago
Closed 7 years ago
Update Folder Icon
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 58
People
(Reporter: shorlander, Assigned: shorlander)
References
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
2.15 KB,
patch
|
johannh
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Update the folder icon to fix some overlapping shapes.
Attachment #8915818 -
Flags: review?(jhofmann)
Comment 2•7 years ago
|
||
Comment on attachment 8915818 [details] [diff] [review] update-folder-icon.patch Review of attachment 8915818 [details] [diff] [review]: ----------------------------------------------------------------- Looks great on my machine, thank you.
Attachment #8915818 -
Flags: review?(jhofmann) → review+
Comment 3•7 years ago
|
||
Inbound is closed and I don't want to add noise, setting checkin-needed.
Flags: qe-verify-
Keywords: checkin-needed
Priority: -- → P1
Whiteboard: [photon-visual] → [reserve-photon-visual]
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/008faf413e3c Update Folder Icon to fix some overlapping areas. r=jhofmann
Keywords: checkin-needed
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/008faf413e3c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment 6•7 years ago
|
||
Verified in Nightly on Win10x64, much better! Btw, not related to this bug, but looks like the fill-opacity is not correctly applied to the sidebar and the Library Window. It seems to only be applied to the main browser window.
Comment 8•7 years ago
|
||
Comment on attachment 8915818 [details] [diff] [review] update-folder-icon.patch Approval Request Comment [Feature/Bug causing the regression]: new Photon design [User impact if declined]: Bookmarks folders icons are bold and look particularly bad with Dark theme [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: replacing an svg icon [String changes made/needed]: none
Attachment #8915818 -
Flags: approval-mozilla-beta?
status-firefox57:
--- → affected
Comment on attachment 8915818 [details] [diff] [review] update-folder-icon.patch Photon polish, Beta57+
Attachment #8915818 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/14dabb8eeb17
You need to log in
before you can comment on or make changes to this bug.
Description
•