1406620 - fill-opacity not applied to sidebar/Library

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Marco Bonardo [:mak]]

I didn't verify, but from the look of it it seems like fill-opacity is not correctly applied to the sidebar and Library windows.
Just compare the bookmarks folder icons from the bookmarks toolbar and the sidebar/Library, the latter are far darker.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1406620 - Set fill-opacity for bookmarks tree icons.

Review commit: https://reviewboard.mozilla.org/r/187456/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187456/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8916224 [details]
Bug 1406620 - Set fill-opacity for bookmarks tree icons.

https://reviewboard.mozilla.org/r/187456/#review192548

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d57a2f1a2f66
Set fill-opacity for bookmarks tree icons. r=mak

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8916224 [details]
Bug 1406620 - Set fill-opacity for bookmarks tree icons.

Approval Request Comment
[Feature/Bug causing the regression]: photon polish
[User impact if declined]: icons in the bookmarks sidebar are a bit too dark
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: just setting fill-opacity for these icons
[String changes made/needed]: /

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d57a2f1a2f66

Comment 6

[Marco Bonardo [:mak]]

verified on Nightly Win10x64.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916224 [details]
Bug 1406620 - Set fill-opacity for bookmarks tree icons.

Photon polish, Beta57+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4533abfd5e9c

Comment 9

[Vlad Bacia-Mociran [:VladB]]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171011220113

This issue has been verified on latest Firefox Nightly Build ID: 20171011220113 on Windows 8.1 x64, Mac OS 10.12 and Ubuntu 14.04. The bookmarks folders from the Bookmark sidebar are a little darker than the folders from Bookmarks toolbar. This is noticeable with a color picker, with the naked eye this is barely visible. If this is expected than the issue is Verified as Fixed.

Comment 10

[Marco Bonardo [:mak]]

I cannot honestly see nothing with bare eyes on a quite modern IPS monitor. Fwiw, there is opacity applied here and the background is different, so it's possible there is a slight difference. Imo it's fine.
I'm forwarding to Dao as theme owner.

Comment 11

[Dão Gottwald [:dao]]

Yep, that's fine.

Comment 12

[Gabi Cheta [:Gabi] Desktop QA]

Setting issue to 57 verified per Dao's comment.