Closed Bug 1406331 Opened 7 years ago Closed 7 years ago

No window controls and resize options available for dialog boxes on macOS

Categories

(Firefox :: Theme, defect)

56 Branch
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox56 + wontfix
firefox57 + fixed

People

(Reporter: manasthakur17, Unassigned)

References

Details

Attachments

(1 file)

Attached video firefox-resize-bug.mov
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170926190823

Steps to reproduce:

1. Start a download.
2. Click on "Show all downloads" from the menu bar.


Actual results:

The download box expands the whole screen. There are no window controls and no way to resize the box. (A screen recording is attached.)
Actually, this problem has been happening since at least two years on my machine (from older Firefox versions). The same thing happens with the dialog boxes created by addons such as "Downthemall". I uninstalled Firefox, and reinstalled it as well, but the problem persists.


Expected results:

The dialog box should be opened as a small window, with window controls as well as resizing options available.
Component: Untriaged → Bookmarks & History
(In reply to Manas Thakur from comment #0)
> Actually, this problem has been happening since at least two years on my
> machine (from older Firefox versions). The same thing happens with the
> dialog boxes created by addons such as "Downthemall". I uninstalled Firefox,
> and reinstalled it as well, but the problem persists.

You might want to try running in safe mode https://support.mozilla.org/kb/troubleshoot-firefox-issues-using-safe-mode in case an add-on is causing it.

Given that this also happens with other windows, I'm moving this to the Theme component, as I think that's more appropriate.
Component: Bookmarks & History → Theme
[Tracking Requested - why for this release]: Two different reports of this today, seems to be a sudden usability issue on Mac.
Maybe a 10.13 issue?   Andrei, can your team confirm this and see if it affects 57/58?
Flags: needinfo?(andrei.vaida)
The reporter for the bug I opened (bug 1406424) just mentioned to me that safe mode solved the problem for him, so it is likely an addon issue. He is still trying to figure out which addon and I couldn't see any theme related addons in his config.
Hi,

OP here. Two things:

1. Out of the two duplicates, one is mine itself; I had thought the bug didn't get registered.
2. This problem is not new in 10.13; it has been affecting me since about two years with the dialog boxes for extensions. However, I noticed (after removing the Downthemall manager, I started using the native Firefox downloads) today that the problem happens with the Firefox download window as well.

p.s. As suggested above, I will check if this happens in safe mode and reply back in about 12 hours, when I access my system again.

Thanks and regards,
Manas
Just in case it is helpful, I am using ublock origin and download YouTube videos as MP4 add-ons, without any modifications. I was using Downthemall too, but have removed or recently.

Anyway, I will try safe mode and reply back tomorrow.
Hello all,

Even though the problem goes away if I start Firefox in safe mode, it still persists if I disable all of my addons. What could be the cause now? Is there a way some uninstalled plugin that caused this could still be affecting the settings?
I tried to reproduce the bug using Firefox 56.0 on macOS 10.13, but I couldn't. I installed ublock, several add-ons for downloading youtube videos and Downthemall, but the download pop-up looked as it should. The window was small and had all the controls.
Can you please tell me all the add-ons you have installed? Or it's just these three? Also, can you please give me the link to the youtube downloader you use? There are too many and I am not sure I installed the one you have. 

Or, if you have the time can you please see if you can recreate the bug using this two versions of Firefox with a clean profile:

1. https://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/ - from this link you have to download the file "firefox-57.0a1.en-US.mac.dmg"

2. https://archive.mozilla.org/pub/firefox/candidates/57.0b7-candidates/build1/mac/en-US/ - from this link you have to download the file "Firefox 57.0b7.dmg"

You just have to install the application and create a new profile. To do that you have to follow the steps from this link https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles.
Flags: needinfo?(andrei.vaida) → needinfo?(manasthakur17)
Okay. Found the way to reproduce the bug. Importantly, I am able to reproduce it in Firefox 57 as well (the nightly link provided above).

Steps to reproduce the bug:

1. Click the download-progress icon.
2. Click on "Show All Downloads".
3. Make the downloads dialog box full-screen using the standard macOS key combination: "Cmd+Ctrl+F".
4. Now the downloads dialog box doesn't have any window controls!!

p.s. Browsing over Firefox docs, I found that if I delete the file "~/Library/Application Support/Firefox/Profiles/x50bvwcw.default/xulstore.json", the bug resolves.
I found that when I reproduced this bug, I can resize the box by using Cmd+Ctrl+F again. However, when I reported this issue (before deleting the xulstore.json file), even that was not working.

Anyway, even in the reproduced version, the window controls should still be present in the fullscreen download/history windows, right? They are present in a full-screen normal Firefox window (can be accessed by hovering to the top).
Flags: needinfo?(manasthakur17)
Probably the fullscreen command should not even be allowed in download/history windows. I checked in some other applications (iTerm2, Eclipse), and using Cmd+Ctrl+F in preference windows, for example, does not do anything.
Depends on: 1407638
I managed to reproduce the bug on macOS 10.13, macOS 10.12 and Mac OS 10.11, but unfortunately I can't find the regression, because it's not always reproducible. 

But the biggest problem is that on latest Nightly and beta 57.0b7 the keyboard shortcut Cmd+Ctrl+F is not working anymore. So I can't verify if the problem is fixed or not at the moment.
As I commented in bug 1407638, the fact that you can get into full screen mode is a bug in FF 56. We have code that intentionally disables the full screen option:

http://searchfox.org/mozilla-central/rev/31606bbabc50b08895d843b9f5f3da938ccdfbbf/browser/base/content/browser.js#1922

The disabling of the menu option isn't working in 56 as bug 1381853 caused a regression. That has been fixed in 57.0b3 onwards by bug 1402059.

There is an issue with there being two menu options in the view menu that both are "Enter Full Screen", however, that was an issue from before FF 56. I've filed that as bug 1408118.


However, I think the basic issue here of the window not having decorations, is a result of it being in full-screen accidentally due to the regression. The fix in 57 will stop that happening in future.

So I think this is a won't fix.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Thank you all.
I keep reporting bugs and try following them up in many forums. But my experience with Firefox has been awesome.
Keep it up :)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: