1406531 - Support remote layer trees in popups on OS X

Status: RESOLVED WORKSFORME

(WebExtensions :: Frontend, enhancement, P2)

Description

[Andy McKay]

This is a fork off of bug 1356317 comment 23 where we changed that bug to be Windows specific. It looks like the main work to be done is in bug 1356317 comment 21 from Jim:

OSX: parts of bug 1291457 + "more work" for shadows - bug 1356317 comment 15"

I've attached two screenshots of an add-on with oop on and oop off (that's the extensions.webextensions.remote pref).

Comment 1

[Andy McKay]

Attachment: Screenshot 2017-10-06 13.38.54.png

extensions.webextensions.remote = false

Comment 2

[Andy McKay]

Attachment: Screenshot 2017-10-06 13.40.33.png

extensions.webextensions.remote = true

Comment 3

[:shell escalante]

Hi Markus,

Do you have any update on progress for this bug?

Comment 4

[Markus Stange [:mstange]]

Hi Shell, I'm really sorry about the delay here. Today I rebased my old patches that I thought would be necessary to fix this bug, and found out that none of them actually were necessary.

We already support remote layer trees in popups, we just turn off the shadow for them. Turning the shadow back on seems to work without causing any of the artifacts that we were expecting to see. I've attached a patch to bug 1370131 that turns shadows back on.

So, the current road to OOP Web extensions on Mac is:
 1. Close this bug as WFM.
 2. Land the patch in bug 1370131.
 3. Flip extensions.webextensions.remote to true on Mac by default.
 4. Optionally fix bug 1341913 so that panel opening doesn't slow down by 50ms.