140669 - [PATCH]Print Margins Gap Settings do not work

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[John Cirillo]

These are the settings for adjusting the gap 
between the edge of the paper and the 
headers/footers (URL, page, date, etc).
The ones I refer to are available in
File - Print - Properties.
Although these margins can be changed and saved, 
they do not actually adjust anything on the printed page.
I have the problem that my printer at the default margin 
won't print the top headers at all, and the left side of 
the footers get chopped, so that's how I came to adjust 
these settings.
Prior to around the 2002-04-03 build, these settings worked. 
That was when the prefs were being saved out as
user_pref("print.print_edge_top", 20); for example. 
After that, the prefs were changed to things such as:
user_pref("print.printer_PostScript/default.print_edge_top", 50);
These new settings, while they are correctly saved to prefs.js, 
do not act upon the printed page in any way that I can see.
I have resorted to adding back the previous user pref as shown above 
as a kind of hard-wired setting that I can edit manually if necessary.

John Cirillo

Comment 1

[Boris Zbarsky [:bzbarsky]]

Roland, this is yours....

Comment 2

[Boris Zbarsky [:bzbarsky]]

Confirming this.  The only reason it's working for me is that I have the old
"print.print_edge_*" preferences in my profile.  The new
"print.printer_PostScript/default.print_edge_*" preferences get set, but the
actual print system never looks at them.

Comment 3

[Boris Zbarsky [:bzbarsky]]

*** Bug 141436 has been marked as a duplicate of this bug. ***

Comment 4

[rods (gone)]

The problem code is down in the nsSimplePageSequence.cpp, it isn't using the
print name to prefice the attr name.

Comment 5

[rods (gone)]

Attachment: patch

The problem here is the "edge" prefs are now preficed with the printer name,
and the nsPrintOptions know how to convert the printer name, so we need to add
a helper method to nsIPrintOptions.idl so the nsSimplePageSeq can get the
ptroperly named value.

Comment 6

[dcone (gone)]

Comment on attachment 84045 [details] [diff] [review]
patch

r=dcone

Comment 7

[Marc Attinasi]

Comment on attachment 84045 [details] [diff] [review]
patch

sr=attinasi

Comment 8

[rods (gone)]

fixed

Comment 9

[Roland Mainz]

rods:
Thanks!

----

bz:
Can you verify, please ?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Not until Mid-June.  Verification is trivial:

1)  Set the gaps to 2 inches
2)  Print and see whether the headers are offset 2 inches from the paper edge.

Comment 11

[rods (gone)]

The internals clamp at an inch, any more than that seemed excessive.

Comment 12

[Roland Mainz]

rods wrote:
> The internals clamp at an inch, any more than that seemed excessive.

Can we adjust that to either 1/10 of the page width/height or 10 inch in
general, please ?
Two inches are not excessive if you print on DIN-A0... think BIG! :)

Comment 13

[sujay]

John, can you verify this one ? thanks.

Comment 14

[John Cirillo]

Yes, I confirmed it is working as expected now.
Thanks!
John

Comment 15

[sujay]

marking verified per comments.